Skip to content

payment failure metric for invalid evm scheme #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dixitaniket wants to merge 1 commit into
base: main
Choose a base branch
from
Open

payment failure metric for invalid evm scheme #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 37 additions & 7 deletions payment_worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,34 @@ function paymentAmountToMetricValue(amount: string): number | null {
return Number.isFinite(parsed) ? parsed : null;
}

function metricTagValue(value: string | undefined, fallback = "unknown"): string {
const normalized = value?.trim().toLowerCase();
if (!normalized) {
return fallback;
}

return normalized.replace(/[^a-z0-9_.:-]+/g, "_").slice(0, 100) || fallback;
}

function paymentSettlementTags(
paymentRequirements: PaymentSettlementJobData["paymentRequirements"],
): string[] {
return [
"worker:payment",
`network:${metricTagValue(paymentRequirements.network)}`,
`asset:${metricTagValue(paymentRequirements.asset)}`,
`scheme:${metricTagValue(paymentRequirements.scheme)}`,
];
}

function settlementFailureReason(errorReason: unknown): string {
if (typeof errorReason !== "string") {
return "unknown";
}

return metricTagValue(errorReason.split(":")[0], "unknown");
}

const worker = new Worker<PaymentSettlementJobData>(
PAYMENT_QUEUE_NAME,
async (job: { id?: string; data: PaymentSettlementJobData }) => {
Expand All @@ -30,15 +58,9 @@ const worker = new Worker<PaymentSettlementJobData>(
...summarizePaymentPayload(paymentPayload),
});
const result = await facilitator.settle(paymentPayload, paymentRequirements);
const tags = paymentSettlementTags(paymentRequirements);

if (result.success) {
const tags = [
"worker:payment",
`network:${paymentRequirements.network}`,
`asset:${paymentRequirements.asset}`,
`scheme:${paymentRequirements.scheme}`,
];

incrementMetric("payment.settled.count", tags);

const amountValue = paymentAmountToMetricValue(paymentRequirements.amount);
Expand All @@ -63,6 +85,14 @@ const worker = new Worker<PaymentSettlementJobData>(
...summarizeError(error),
});
}
} else {
const reason = settlementFailureReason(result.errorReason);
const failureTags = [...tags, `reason:${reason}`];
incrementMetric("payment.settlement.failed.count", failureTags);

if (reason.startsWith("invalid_exact_evm")) {
incrementMetric("payment.settlement.invalid_evm.count", failureTags);
}
}

return result;
Expand Down
Loading