fix(config): correct TIPSv2 embedding filename to crop_384x384 - #16
Open
ZhuoyaoH wants to merge 1 commit into
Open
fix(config): correct TIPSv2 embedding filename to crop_384x384#16ZhuoyaoH wants to merge 1 commit into
ZhuoyaoH wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The TIPSv2 embedding dataset file was misnamed
TIPSv2_b14_crop_448x448.parquet. Source patches in Core-S2L2A-249k are fixed at 384x384; generation took the full 384x384 patch and resized it to the 448x448 model input, so no 448x448 crop ever existed. Per the project naming convention (crop size = source patch crop, e.g. FarSLIP crop 384 / input 224), the correct name isTIPSv2_b14_crop_384x384.parquet.Changes on the dataset side (already done in
Major-TOM/Core-S2RGB-249k-TIPSv2):TIPSv2_b14_crop_384x384.parquet(byte-verified, 815,473,248 bytes).pixel_bboxcolumn from[0,0,448,448]to[0,0,384,384](embeddings,unique_idand row count verified unchanged).This PR updates the only in-repo reference:
configs/config.yamltipsv2.embedding_path.Impact
None on retrieval:
pixel_bboxis not consumed anywhere in the app code, and embeddings are untouched.Test plan
ms://Major-TOM/Core-S2RGB-249k-TIPSv2/TIPSv2_b14_crop_384x384.parquet.