Add Patron EG brand with PLA+, Matte PLA and 2 more filaments and 4 variants#376
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Patron EG brand dataset entry to the Open Filament Database, including PLA and PETG material families, several filament lines, and marble-PLA color variants.
Changes:
- Added
data/patron_egbrand metadata and logo. - Added PLA + PETG materials and filament-line metadata (PLA+, Matte PLA, Marble PLA, PETG HS).
- Added 4 Marble PLA variants (with sizes, and one purchase link).
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| data/patron_eg/brand.json | Defines Patron EG brand metadata (id, name, website, logo, origin). |
| data/patron_eg/logo.png | Adds the brand logo referenced by brand.json. |
| data/patron_eg/PLA/material.json | Adds PLA material metadata for the brand. |
| data/patron_eg/PLA/pla/filament.json | Adds filament line metadata for “PLA+” (source id currently pla). |
| data/patron_eg/PLA/matte_pla/filament.json | Adds filament line metadata for “Matte PLA”. |
| data/patron_eg/PLA/marble_pla/filament.json | Adds filament line metadata for “Marble PLA”. |
| data/patron_eg/PLA/marble_pla/white_marble_pla/variant.json | Adds “White Marble” variant metadata (traits + color). |
| data/patron_eg/PLA/marble_pla/white_marble_pla/sizes.json | Adds size + purchase link for White Marble variant. |
| data/patron_eg/PLA/marble_pla/mocha_marble_pla/variant.json | Adds “Mocha Marble” variant metadata (traits + color). |
| data/patron_eg/PLA/marble_pla/mocha_marble_pla/sizes.json | Adds size data for Mocha Marble variant. |
| data/patron_eg/PLA/marble_pla/baby_blue_marble/variant.json | Adds “Baby Blue Marble” variant metadata (traits + color). |
| data/patron_eg/PLA/marble_pla/baby_blue_marble/sizes.json | Adds size data for Baby Blue Marble variant. |
| data/patron_eg/PLA/marble_pla/turquoise_marble/variant.json | Adds “Turquoise Marble” variant metadata (traits + color). |
| data/patron_eg/PLA/marble_pla/turquoise_marble/sizes.json | Adds size data for Turquoise Marble variant. |
| data/patron_eg/PETG/material.json | Adds PETG material metadata for the brand. |
| data/patron_eg/PETG/petg_hs/filament.json | Adds filament line metadata for “PETG HS”. |
Comment on lines
+2
to
+3
| "id": "pla", | ||
| "name": "PLA+", |
| @@ -0,0 +1,9 @@ | |||
| { | |||
| "id": "mocha_marble_pla", | |||
Collaborator
|
LGTM other than the issues, will merge and push fixes for them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitted via Open Filament Database web editor.
Changes
Submitted via SimplyPrint