Add 3DHoJor brand with Light Khaki filament#362
Closed
ofd-anon-pr-bot[bot] wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new 3DHoJor brand entry to the Open Filament Database, introducing initial PLA material metadata and a first filament entry intended to represent “Light Khaki”.
Changes:
- Added
brand.jsonfor the new3dhojorbrand. - Added
material.jsonforPLAwith a default max dry temperature. - Added a PLA filament entry under
light_khaki/filament.json.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| data/3dhojor/brand.json | Introduces new brand metadata (id/name/website/logo/origin). |
| data/3dhojor/PLA/material.json | Adds PLA material defaults for the new brand. |
| data/3dhojor/PLA/light_khaki/filament.json | Adds initial filament record (currently modeled as a color-like entry). |
Comment on lines
+2
to
+3
| "id": "light_khaki", | ||
| "name": "Light Khaki", |
Contributor
|
Needs fixing ^ |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
|
Sadly gonna have to close this as "Light Khaki" is a color, but you're submitting it as both a color and filament, without actually submitting the filament. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitted via Open Filament Database web editor.
Changes
Submitted via SimplyPrint