Repository navigation
Analysis - BUGFIX - Read Jb_theta and Jb_zeta and smoke-test the gpec.h5 plots - #573
Merged
Merged
Conversation
logan-nc
reviewed
Oct 26, 2026
logan-nc
left a comment
Collaborator
There was a problem hiding this comment.
Read in full. Ready to approve from my read once #568 lands and this retargets; nothing to add. Both renames match the writers, the ψ axis change is the response's own grid, and the smoke test is the right shape (real writer output, placeholder detection, the old component names asserted to throw).
matt-pharr
force-pushed
the
bugfix/analysis-h5-readers
branch
from
October 26, 2026 10:08
bc9e134 to
ecd0160
Compare
logan-nc
approved these changes
Oct 26, 2026
…si, and smoke-test the gpec.h5 plots
matt-pharr
force-pushed
the
bugfix/analysis-h5-readers
branch
from
October 26, 2026 21:00
ecd0160 to
cd0adf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note
plot_mode_spectrogramcomponents:b_thetaand:b_zetaare now:Jb_thetaand:Jb_zeta, named after theJb_theta/Jb_zetadatasets they plot; the old names raise the invalid-component error.The mode spectrogram now draws the Jacobian-weighted poloidal and toroidal field components instead of always showing "No response data", and
plot_cond_fbarno longer throws aKeyErroron every run. Both read dataset names the writers had stopped producing. A new smoke test draws everygpec.h5plot from real writer output, so a renamed dataset now fails the tests.Regression report
Notes for reviewers
feature/local-stability-problem); the base and the regression baseline are that branch. It retargets to develop when LocalStability - API! - Solve a LocalStabilityProblem from its own deck section #568 merges.gpec.h5plot on its output. All 54 literal dataset paths in the Equilibrium, ForceFreeStates and PerturbedEquilibrium plot files exist in that file; the two breaks were in names the readers spell differently from the writers:plot_mode_spectrogramreadResponse/b_thetaandb_zeta, which the writer emits asJb_thetaandJb_zeta. Its ψ axis now comes fromPerturbedEquilibrium/Response/psi, the response's own grid, instead ofForceFreeStates/Solutions/ForwardIntegration/psi(identical on a forward run).plot_cond_fbarreadSingularSurfaces/Kinetic/psi, which the writer emits asrational_psi. On an ideal run theKineticgroup exists with empty datasets, so theKeyErrorfired before the documentedreturn nothing.test/runtests_analysis_plots.jlruns two coarse fixtures (about 25 s):regression_solovev_ideal_examplewith one PF hoop and the PE response, where every Equilibrium, ForceFreeStates and PE plot and summary must draw without a "No ..." placeholder, all four spectrogram components draw, and the optional kinetic and GSE plots returnnothing; andregression_solovev_kinetic_example, whereplot_cond_fbardraws the scan. With the two fixes reverted the file fails five checks.gse.h5/gsei.h5besidegpec.h5, but the Equilibrium writer puts them besideeq_filename(the working directory for analytic equilibria, whereeq_filenameis empty). Equilibrium - BUGFIX - Write gse.h5 and gsei.h5 when diagnose_src is set #522 is changing that writer, so the fix belongs there or in a follow-up.nothing, placeholder plot, empty result).Analysis.ErrorFields._load_h5duplicates the ErrorFields readers (CoilSensitivities(h5path),MonteCarloResult(h5path)).🤖 Generated with Claude Code