Repository navigation
PerturbedEquilibrium - BUGFIX! - Refuse Galerkin and matched results until they publish wp - #556
Merged
Merged
Conversation
…until they publish wp
…refuse-unpublished-wp
…zation' into bugfix/pe-refuse-unpublished-wp
Base automatically changed from
bugfix/deck-file-forcing-normalization
to
develop
October 24, 2026 17:32
logan-nc
reviewed
Oct 26, 2026
logan-nc
left a comment
Collaborator
There was a problem hiding this comment.
Read in full. Ready to approve from my read.
The refusal is in the one shared function, keys on free_boundary so it lifts itself, and the harness shows the eight gal_resistive_pe rows N/A on both refs as the body says. One consistency note for later, not for this PR: #574 removes the "set both flags false" escape hatch this Migration line recommends (Galerkin/matched results then error at plasma_response unconditionally and the example moves to force_termination), so the two migration notes will disagree once both land. #574's should mention that it supersedes this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note
MatchProblem, now stops with an error. Setcompute_response = falseandcompute_singular_coupling = falsefor such a run, or use a forward solve.The plasma response and singular coupling need the free-boundary δW. Galerkin and inner-layer-matched results don't carry it yet, so on those results PerturbedEquilibrium used to log a warning and return an output holding only the forcing modes. It now raises an error that says why. The error lifts once those results publish the plasma edge response
wp.Regression report
SDCC fan-out,
regress --cases gal_resistive_pe,diiid_n1 --refs develop,bugfix/pe-refuse-unpublished-wp(develop @ 1cb9bf0, now that #549 has merged; branch @ 13d7738 after merging develop in; Julia 1.12.6 with the CI manifest pin). Nothing moves.gal_resistive_pereads all N/A on both refs, as it did before this change, because PE skipped these steps; both runs complete.diiid_n1is the forward-solve control.Full report
Notes for reviewers
The refusal.
compute_perturbed_equilibriumerrors when all three hold:compute_responseorcompute_singular_couplingis requested;:matchedclosure;free_boundary.It checks
free_boundaryitself, so the refusal lifts on its own when a later change publisheswpfrom closed Galerkin and matched results. It sits in the one function the deck, the scripting API andefc_couplingsall share. A matched Riccati result is caught by the closure check. With both steps off, PE still materializes the forcing, so a staged deck runs.Unchanged on purpose. A Riccati result, which has no ξ solution, and a forward run with
vac_flag = false, which has no free-boundary energies, still warn and skip. They are outside this change.gal_resistive_pe. The harness has no "expected N/A" flag, and an error would have made the case show FAILED and broken the example for anyone running it. So the example keeps its coil forcing and[PerturbedEquilibrium]section, ready for whenwplands, with the two steps switched off. Its harness case header says the PE quantities are expected N/A; all eight tracked datasets are underPerturbedEquilibrium/SingularCoupling/.requireloses its:matchedmessage branch, since PE was its only:free_boundarycaller.Tests.
runtests_solve_api.jlnow checks:These reuse solves the file already runs, so they add no extra solves.
🤖 Generated with Claude Code