Repository navigation
ForceFreeStates - FEATURE - Accept the fixed kinetic source in solve(EulerLagrangeProblem) - #550
Merged
Merged
Conversation
matt-pharr
force-pushed
the
feature/solve-fixed-kinetic
branch
from
October 23, 2026 09:44
fb1a739 to
dc408ec
Compare
…EulerLagrangeProblem) solve() rejected every kinetic_factor > 0, although the "fixed" source builds its matrices without kinetic profiles. Only kinetic_source = "calculated" is now refused. Align the Riccati and Galerkin Forward-only error messages, and add a deck/API parity test at kinetic_factor = 1e-3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… solves and describe the calculated kinetic source solve() now rejects kinetic_factor > 0 with Riccati() or Galerkin() before the metric and matrices are built, and the ForceFreeStatesControl docstring describes what the "calculated" kinetic source is instead of calling it unimplemented. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
matt-pharr
force-pushed
the
feature/solve-fixed-kinetic
branch
from
October 23, 2026 09:52
dc408ec to
0d7b8fe
Compare
…on instead of failing in the edge scan solve_el never checked the solver's return code, so a solve that stopped short (e.g. the step size underflowing) was stored as if it had reached the end of its interval, and the forward sweep later failed in findmax_dW_edge! with a MethodError. solve_el now errors with the ψ reached, the target and the return code. Covers the forward solve and the Riccati propagator solves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
logan-nc
reviewed
Oct 26, 2026
logan-nc
left a comment
Collaborator
There was a problem hiding this comment.
Read in full. Ready to approve from my read; nothing to add. The "fixed" source path genuinely never reads the placeholder control or the nothing profiles (the axis-validity boundary is only consulted on the "calculated" branch), and the three rejection tests match on message text so a reworded guard cannot pass by accident.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note
solve(EulerLagrangeProblem, Forward())now runs kinetic stability problems withkinetic_source = "fixed", which previously only worked from agpec.tomldeck. The"calculated"source still needs the[KineticForces]profiles and remains deck-only. Kinetic runs withRiccati()orGalerkin()now fail immediately with a clear message.Regression report
Notes for reviewers
"fixed"source builds its X-shaped test matrices inbuild_kinetic_matrix_splineswithout the KineticForces callback. The axis-validity boundary is0.0when no profiles are loaded and is only used in the"calculated"branch. So the placeholderKineticForcesControl()andnothingprofiles thatsolvepasses are never read on this path. Thesolveguard now rejects onlykinetic_source = "calculated".solvechecksRiccati()/Galerkin()+kinetic_factor > 0before the metric and matrices are built. The deeper guards stay for the deck path, and the Riccati messages now match the Galerkin one.ForceFreeStatesControldocstring now describes the"calculated"source instead of calling it unimplemented.runtests_solve_api.jl:solve(...; kinetic_factor=1e-3)againstmainon the coarse Solovev fixture. It checkset[1]andpsilimtortol=1e-12, plusnzero, the mode range and the kinetic singular surfaces. The rejection tests match on the error message.@test_broken. Whichever of Test - TEST - Add deck/API parity tests with the known drifts marked broken #546 and ForceFreeStates - FEATURE - Accept the fixed kinetic source in solve(EulerLagrangeProblem) #550 merges second turns it into a pass and drops the duplicate.🤖 Generated with Claude Code