Skip to content

Build - BUGFIX! - Bump FastInterpolations to v0.4.20 for the Periodic BC fix - #532

Merged
logan-nc merged 5 commits into
developfrom
bugfix/fastinterpolations-0.4.20
Oct 24, 2026
Merged

Build - BUGFIX! - Bump FastInterpolations to v0.4.20 for the Periodic BC fix#532
logan-nc merged 5 commits into
developfrom
bugfix/fastinterpolations-0.4.20

Conversation

@matt-pharr

@matt-pharr matt-pharr commented Oct 16, 2026 •
edited by logan-nc
Loading

Copy link
Copy Markdown
Collaborator

Bumps FastInterpolations to v0.4.20, which fixes its periodic boundary condition. Closes #531.

The issue it was waiting on, #525, turned out to be a red herring and is closed, so this PR is no longer blocked.

Release note

  • Audience: users
  • Numerical impact: results move slightly. Solovev ideal energies change by about 2e-4 relative, DIII-D-like energies by under 1e-6, the Riccati Δ′ diagonal by up to 0.15%, SLAYER growth rates by up to 0.07%, and ODE step counts by under 1% (harness @ 067f6d2)
  • Migration: run Pkg.instantiate() to pick up FastInterpolations v0.4.20. Expect small differences when comparing against outputs from earlier builds.

FastInterpolations v0.4.20 fixes a bug in its periodic boundary condition, which GPEC's splines use. Results shift only slightly.

Regression report

Run on alfven, Julia 1.11.7, 32 threads, job 783. Four refs form a 2×2 grid: FastInterpolations 0.4.18 or 0.4.20, each with and without #555 (singfac_min). Each ref is the named commit plus one commit that pins the root Manifest.toml to that FastInterpolations version. test/fi20-532 (8a39efaf3) has the same src/ as this PR's head, 067f6d20e.

Comparison What it isolates Result
fi18-dev → fi20-532 this bump on develop 9a51446df small moves, listed in the release note
fi18-555 → fi20-532-555 this bump on top of #555 the same size of move, so the two PRs do not interact

Neither PR depends on the other, so they can merge in either order. Geometry scalars (q0, q95, β, volume, the li) agree to 1e-7 or better. The profile checksums change because they hash bits, not values.

ggj_ray_q500i failed on every ref, because the harness runner in my checkout predates the develop fix that qualifies InnerLayer.GGJ.q4_surface_benchmark(). It is unrelated to this PR. gal_resistive_pe reports N/A for the per-surface PE Δ′ on every ref.

Changed rows only (the full report is 87 kB, over GitHub's body limit) 
Case: gal_resistive_diiid_galinner — DIII-D-like, n=1, Galerkin Δ′ matched with the Galerkin inner-layer backend
Ref 1: test/fi18-dev  @ ae0f5f1a1
Ref 2: test/fi20-532  @ 8a39efaf3
Ref 3: test/fi18-555  @ 8024b4350
Ref 4: test/fi20-532-555  @ e70285cbb
Quantity                 test/fi18-dev  test/fi20-532  test/fi18-555  test/fi20-532-555  Δ prev             Status       
gal PEST3 Δ diagonal     [4 elem]       [4 elem]       [4 elem]       [4 elem]           7.349e-06 (0.00%)  ** CHANGED **
||gal Δ′ matrix||        1.243817e+04   1.243817e+04   1.243817e+04   1.243817e+04       1.564e-05 (0.00%)  ** CHANGED **
||gal Δ_coil block||     2.437679e+02   2.437679e+02   2.437679e+02   2.437679e+02       7.576e-06 (0.00%)  ** CHANGED **
||gal inner-layer Δ||    1.474568e+06   1.474568e+06   1.474568e+06   1.474568e+06       4.789e-04 (0.00%)  ** CHANGED **
Summary (last vs prev): 4 changed, 7 unchanged
Case: ggj_ray_q500i — GGJ inner-layer :ray backend, q=4 surface, Q = 500i (beyond :galerkin)
  Ref 1 error: ERROR: LoadError: UndefVarError: `q4_surface_benchmark` not defined in `Main`
  Ref 2 error: ERROR: LoadError: UndefVarError: `q4_surface_benchmark` not defined in `Main`
  Ref 3 error: ERROR: LoadError: UndefVarError: `q4_surface_benchmark` not defined in `Main`
  Ref 4 error: ERROR: LoadError: UndefVarError: `q4_surface_benchmark` not defined in `Main`
Re(Δ_odd)    FAILED         FAILED         FAILED         FAILED                     FAILED
Im(Δ_odd)    FAILED         FAILED         FAILED         FAILED                     FAILED
Re(Δ_even)   FAILED         FAILED         FAILED         FAILED                     FAILED
Im(Δ_even)   FAILED         FAILED         FAILED         FAILED                     FAILED
Runtime (s)  FAILED         FAILED         FAILED         FAILED                     --    
Summary (last vs prev): 4 missing/N/A
Case: solovev_kinetic_nuzero — Solovev, n=1, kinetic_source=calculated, nutype=zero (collisionless energy integral), 50/50 D-T multi-ion kinetic matrices, mode-converged band (delta_m=8, mpert=32). Reuses the calculated example deck via override; pressure-consistent kinetic.dat.
Quantity                 test/fi18-dev  test/fi20-532  test/fi18-555  test/fi20-532-555  Δ prev             Status       
vacuum energy Re(ev[1])  1.058735e+01   1.058724e+01   1.058734e+01   1.058723e+01       1.085e-04 (0.00%)  ** CHANGED **
total energy Re(et[1])   2.290309e+00   2.290786e+00   2.290312e+00   2.290789e+00       4.765e-04 (0.02%)  ** CHANGED **
total energy Im(et[1])   -1.564909e+00  -1.564787e+00  -1.564910e+00  -1.564789e+00      1.214e-04 (0.01%)  ** CHANGED **
plasma energy Re(ep[1])  -8.297038e+00  -8.296452e+00  -8.297030e+00  -8.296445e+00      5.850e-04 (0.01%)  ** CHANGED **
ODE steps (saved)        610            606            614            612                2.000e+00 (0.33%)  ** CHANGED **
total energy (all)       [32 elem]      [32 elem]      [32 elem]      [32 elem]          2.400e-01 (0.00%)  ** CHANGED **
ODE steps (total)        609            605            613            611                2.000e+00 (0.33%)  ** CHANGED **
Summary (last vs prev): 7 changed, 7 unchanged
Case: diiid_error_field — DIII-D-like error-field assessment, n=1: ErrorFields stage with the NTV-limited correction couplings
Quantity                                         test/fi18-dev  test/fi20-532  test/fi18-555  test/fi20-532-555  Δ prev             Status       
EFC whole-field NTV torque per kAt² [N·m]        [1 elem]       [1 elem]       [1 elem]       [1 elem]           4.085e-07 (0.00%)  ** CHANGED **
EFC residual torque against rotation [N·m/kAt²]  [9 elem]       [9 elem]       [9 elem]       [9 elem]           3.968e-08 (0.00%)  ** CHANGED **
dominant-coupling singular values                [3 elem]       [3 elem]       [3 elem]       [3 elem]           1.439e-05 (0.00%)  ** CHANGED **
Summary (last vs prev): 3 changed, 7 unchanged
Case: diiid_slayer_n1 — DIII-D-like H-mode equilibrium, n=1, SLAYER tearing-mode analysis (uncoupled per-surface, AMR, validity-gated)
Quantity                            test/fi18-dev  test/fi20-532  test/fi18-555  test/fi20-532-555  Δ prev             Status       
SLAYER minor radius rs              [6 elem]       [6 elem]       [6 elem]       [6 elem]           1.347e-10 (0.00%)  ** CHANGED **
SLAYER r-based shear                [6 elem]       [6 elem]       [6 elem]       [6 elem]           7.461e-06 (0.00%)  ** CHANGED **
SLAYER Lundquist S                  [6 elem]       [6 elem]       [6 elem]       [6 elem]           2.782e+01 (0.00%)  ** CHANGED **
SLAYER D_norm                       [6 elem]       [6 elem]       [6 elem]       [6 elem]           6.081e-07 (0.00%)  ** CHANGED **
SLAYER P_perp                       [6 elem]       [6 elem]       [6 elem]       [6 elem]           3.667e-07 (0.00%)  ** CHANGED **
SLAYER tauk                         [6 elem]       [6 elem]       [6 elem]       [6 elem]           1.691e-11 (0.00%)  ** CHANGED **
SLAYER iota_e                       [6 elem]       [6 elem]       [6 elem]       [6 elem]           7.955e-10 (0.00%)  ** CHANGED **
SLAYER Q_e                          [6 elem]       [6 elem]       [6 elem]       [6 elem]           1.873e-06 (0.00%)  ** CHANGED **
SLAYER Q_i                          [6 elem]       [6 elem]       [6 elem]       [6 elem]           1.320e-06 (0.00%)  ** CHANGED **
SLAYER γ_Hz [2/1,3/1,4/1]           [3 elem]       [3 elem]       [3 elem]       [3 elem]           8.185e-01 (0.07%)  ** CHANGED **
Summary (last vs prev): 10 changed, 7 unchanged
Case: diiid_truncation_n1 — DIII-D-like, n=1, psihigh=0.9999 with the resistive-layer overlap cap binding (truncation only)
Quantity                               test/fi18-dev  test/fi20-532  test/fi18-555  test/fi20-532-555  Δ prev             Status       
psilim                                 9.949767e-01   9.949767e-01   9.949767e-01   9.949767e-01       1.187e-10 (0.00%)  ** CHANGED **
plasma energy Re(ep[1])                -1.372382e+00  -1.372382e+00  -1.377423e+00  -1.377423e+00      1.740e-07 (0.00%)  ** CHANGED **
total energy Re(et[1])                 8.005422e-01   8.005423e-01   7.978561e-01   7.978561e-01       5.735e-08 (0.00%)  ** CHANGED **
Summary (last vs prev): 3 changed, 9 unchanged
Case: gal_resistive_pe — DIII-D-like, n=1, DRIVEN/RPEC: gal-matched resistive ξ → PerturbedEquilibrium (coil-driven singular coupling)
Summary (last vs prev): 8 missing/N/A
Case: solovev_kinetic_calculated — Solovev, n=1, kinetic_source=calculated, kinetic_factor=1.0, 50/50 D-T multi-ion kinetic matrices, mode-converged band (delta_m=8, mpert=32); pressure-consistent kinetic.dat (n·T tied to the Solovev P₀≈4.27e4 Pa).
Quantity                  test/fi18-dev  test/fi20-532  test/fi18-555  test/fi20-532-555  Δ prev             Status       
vacuum energy Re(ev[1])   1.054785e+01   1.054774e+01   1.054785e+01   1.054773e+01       1.183e-04 (0.00%)  ** CHANGED **
||xi_clebsch_alpha||      7.753463e-03   7.754679e-03   8.358308e-03   8.357946e-03       3.614e-07 (0.00%)  ** CHANGED **
total energy Re(et[1])    1.827879e+00   1.828342e+00   1.827881e+00   1.828344e+00       4.629e-04 (0.03%)  ** CHANGED **
total energy Im(et[1])    -1.326825e+00  -1.326722e+00  -1.326827e+00  -1.326723e+00      1.032e-04 (0.01%)  ** CHANGED **
plasma energy Re(ep[1])   -8.719976e+00  -8.719395e+00  -8.719970e+00  -8.719388e+00      5.812e-04 (0.01%)  ** CHANGED **
ODE steps (saved)         609            609            612            611                1.000e+00 (0.16%)  ** CHANGED **
total energy (all)        [32 elem]      [32 elem]      [32 elem]      [32 elem]          2.400e-01 (0.00%)  ** CHANGED **
ODE steps (total)         608            608            611            610                1.000e+00 (0.16%)  ** CHANGED **
||Jb_theta_reg||          8.201669e-05   8.239777e-05   8.229247e-05   8.176637e-05       5.261e-07 (0.64%)  ** CHANGED **
||dxi_clebsch_psi/dpsi||  4.865809e-02   4.866564e-02   5.245673e-02   5.245441e-02       2.320e-06 (0.00%)  ** CHANGED **
Summary (last vs prev): 10 changed, 7 unchanged
Case: gal_resistive_diiid — DIII-D-like, n=1, RDCON outer-region Galerkin Δ′ with rpec coil columns (delta_coil)
Quantity                 test/fi18-dev  test/fi20-532  test/fi18-555  test/fi20-532-555  Δ prev             Status       
gal PEST3 Δ diagonal     [4 elem]       [4 elem]       [4 elem]       [4 elem]           7.349e-06 (0.00%)  ** CHANGED **
||gal Δ′ matrix||        1.243817e+04   1.243817e+04   1.243817e+04   1.243817e+04       1.564e-05 (0.00%)  ** CHANGED **
||gal Δ_coil block||     2.437679e+02   2.437679e+02   2.437679e+02   2.437679e+02       7.576e-06 (0.00%)  ** CHANGED **
||gal inner-layer Δ||    1.474579e+06   1.474579e+06   1.474579e+06   1.474579e+06       7.587e-04 (0.00%)  ** CHANGED **
Summary (last vs prev): 4 changed, 7 unchanged
Case: solovev_n1 — Solovev analytical equilibrium, n=1, ideal stability
Quantity                      test/fi18-dev    test/fi20-532    test/fi18-555    test/fi20-532-555  Δ prev             Status       
total energy Re(et[1])        1.090570e-02     1.090571e-02     7.362674e-03     7.362711e-03       3.690e-08 (0.00%)  ** CHANGED **
plasma energy Re(ep[1])       -1.041640e+01    -1.041640e+01    -1.042157e+01    -1.042157e+01      4.134e-08 (0.00%)  ** CHANGED **
vacuum energy Re(ev[1])       1.042730e+01     1.042730e+01     1.042894e+01     1.042894e+01       4.441e-09 (0.00%)  ** CHANGED **
vacuum matrix min eigenvalue  2.170703e+00     2.170703e+00     2.170703e+00     2.170703e+00       1.868e-10 (0.00%)  ** CHANGED **
plasma energy (all)           [32 elem]        [32 elem]        [32 elem]        [32 elem]          2.306e-05 (0.00%)  ** CHANGED **
vacuum energy (all)           [32 elem]        [32 elem]        [32 elem]        [32 elem]          4.503e-06 (0.00%)  ** CHANGED **
total energy (all)            [32 elem]        [32 elem]        [32 elem]        [32 elem]          2.410e-05 (0.00%)  ** CHANGED **
ODE steps (saved)             287              289              386              387                1.000e+00 (0.26%)  ** CHANGED **
ODE steps (total)             285              287              384              385                1.000e+00 (0.26%)  ** CHANGED **
q profile (checksum)          049799b65749...  260c3629d39c...  049799b65749...  260c3629d39c...    0.000e+00 (0.00%)  ** CHANGED **
pressure profile (checksum)   8339185e550b...  3dc9cd459e40...  8339185e550b...  3dc9cd459e40...    0.000e+00 (0.00%)  ** CHANGED **
ca_left (checksum)            9dd69997cd2f...  b307d1062ea6...  765e21246d11...  102458f9cc8e...    0.000e+00 (0.00%)  ** CHANGED **
Summary (last vs prev): 12 changed, 10 unchanged
Case: ggj_reference — GGJ inner-layer Galerkin solver, Glasser & Wang 2020 Eq. 55, γ = 1+i
  Ref 1 error: ERROR: LoadError: UndefVarError: `glasser_wang_2020_eq55` not defined in `Main`
  Ref 2 error: ERROR: LoadError: UndefVarError: `glasser_wang_2020_eq55` not defined in `Main`
  Ref 3 error: ERROR: LoadError: UndefVarError: `glasser_wang_2020_eq55` not defined in `Main`
  Ref 4 error: ERROR: LoadError: UndefVarError: `glasser_wang_2020_eq55` not defined in `Main`
Re(Δ_odd)    FAILED         FAILED         FAILED         FAILED                     FAILED
Im(Δ_odd)    FAILED         FAILED         FAILED         FAILED                     FAILED
Re(Δ_even)   FAILED         FAILED         FAILED         FAILED                     FAILED
Im(Δ_even)   FAILED         FAILED         FAILED         FAILED                     FAILED
Runtime (s)  FAILED         FAILED         FAILED         FAILED                     --    
Summary (last vs prev): 4 missing/N/A
Case: solovev_multi_n — Solovev analytical equilibrium, multi-n, ideal stability
Quantity                      test/fi18-dev    test/fi20-532    test/fi18-555    test/fi20-532-555  Δ prev             Status       
total energy Re(et[1])        -2.134718e+00    -2.134718e+00    -2.134718e+00    -2.134718e+00      2.309e-09 (0.00%)  ** CHANGED **
vacuum matrix min eigenvalue  1.730832e+00     1.730832e+00     1.730832e+00     1.730832e+00       1.144e-10 (0.00%)  ** CHANGED **
plasma energy (all)           [70 elem]        [70 elem]        [70 elem]        [70 elem]          1.190e-06 (0.00%)  ** CHANGED **
vacuum energy (all)           [70 elem]        [70 elem]        [70 elem]        [70 elem]          4.256e-06 (0.00%)  ** CHANGED **
total energy (all)            [70 elem]        [70 elem]        [70 elem]        [70 elem]          3.975e-06 (0.00%)  ** CHANGED **
ODE steps (total)             1044             1043             1044             1043               1.000e+00 (0.10%)  ** CHANGED **
q profile (checksum)          049799b65749...  260c3629d39c...  049799b65749...  260c3629d39c...    0.000e+00 (0.00%)  ** CHANGED **
Summary (last vs prev): 7 changed, 8 unchanged
Case: diiid_n1 — DIII-D-like equilibrium, n=1, ideal + perturbed equilibrium
Quantity                                      test/fi18-dev    test/fi20-532    test/fi18-555    test/fi20-532-555  Δ prev             Status       
total energy Re(et[1])                        8.006120e-01     8.006120e-01     7.979260e-01     7.979260e-01       3.971e-08 (0.00%)  ** CHANGED **
plasma energy Re(ep[1])                       -1.372262e+00    -1.372262e+00    -1.377302e+00    -1.377302e+00      5.682e-08 (0.00%)  ** CHANGED **
vacuum energy Re(ev[1])                       2.172874e+00     2.172874e+00     2.175228e+00     2.175228e+00       9.653e-08 (0.00%)  ** CHANGED **
plasma energy (all)                           [35 elem]        [35 elem]        [35 elem]        [35 elem]          4.184e-04 (0.00%)  ** CHANGED **
vacuum energy (all)                           [35 elem]        [35 elem]        [35 elem]        [35 elem]          1.013e-04 (0.00%)  ** CHANGED **
total energy (all)                            [35 elem]        [35 elem]        [35 elem]        [35 elem]          3.171e-04 (0.00%)  ** CHANGED **
ODE steps (saved)                             786              792              1179             1166               1.300e+01 (1.10%)  ** CHANGED **
ODE steps (total)                             781              787              1174             1161               1.300e+01 (1.11%)  ** CHANGED **
q0                                            1.204212e+00     1.204212e+00     1.204212e+00     1.204212e+00       1.717e-10 (0.00%)  ** CHANGED **
q95                                           4.781723e+00     4.781723e+00     4.781723e+00     4.781723e+00       3.842e-09 (0.00%)  ** CHANGED **
beta_t                                        1.327024e-02     1.327024e-02     1.327024e-02     1.327024e-02       3.762e-10 (0.00%)  ** CHANGED **
beta_n                                        1.372511e+00     1.372511e+00     1.372511e+00     1.372511e+00       3.891e-08 (0.00%)  ** CHANGED **
internal inductance li1                       8.842269e-01     8.842269e-01     8.842269e-01     8.842269e-01       1.720e-08 (0.00%)  ** CHANGED **
internal inductance li2                       7.080757e-01     7.080757e-01     7.080757e-01     7.080757e-01       6.413e-09 (0.00%)  ** CHANGED **
internal inductance li3                       7.304341e-01     7.304340e-01     7.304341e-01     7.304340e-01       6.616e-09 (0.00%)  ** CHANGED **
poloidal beta betap1                          6.680739e-01     6.680739e-01     6.680739e-01     6.680739e-01       1.894e-08 (0.00%)  ** CHANGED **
poloidal beta betap2                          5.349836e-01     5.349836e-01     5.349836e-01     5.349836e-01       8.796e-11 (0.00%)  ** CHANGED **
poloidal beta betap3                          5.518764e-01     5.518764e-01     5.518764e-01     5.518764e-01       9.074e-11 (0.00%)  ** CHANGED **
current beta betaj                            4.236480e-01     4.236480e-01     4.236480e-01     4.236480e-01       6.039e-09 (0.00%)  ** CHANGED **
plasma volume                                 1.829472e+01     1.829472e+01     1.829472e+01     1.829472e+01       5.216e-07 (0.00%)  ** CHANGED **
q profile (checksum)                          39d9421352fb...  549ab41cae62...  39d9421352fb...  549ab41cae62...    0.000e+00 (0.00%)  ** CHANGED **
pressure profile (checksum)                   4dcd02ebd430...  46df23b5c0f0...  4dcd02ebd430...  46df23b5c0f0...    0.000e+00 (0.00%)  ** CHANGED **
Mercier D_I profile (checksum)                8f2e24b7a722...  c1144fa7136e...  8f2e24b7a722...  c1144fa7136e...    0.000e+00 (0.00%)  ** CHANGED **
resistive interchange D_R profile (checksum)  9cc3fb326bf3...  4ef2f6e16cfb...  9cc3fb326bf3...  4ef2f6e16cfb...    0.000e+00 (0.00%)  ** CHANGED **
ballooning Delta' profile (checksum)          b9e975c03644...  5e9e84ea37d6...  b9e975c03644...  5e9e84ea37d6...    0.000e+00 (0.00%)  ** CHANGED **
island half-widths                            [5 elem]         [5 elem]         [5 elem]         [5 elem]           1.370e-07 (0.00%)  ** CHANGED **
Chirikov parameter                            [5 elem]         [5 elem]         [5 elem]         [5 elem]           8.620e-06 (0.00%)  ** CHANGED **
dominant-coupling singular values             [3 elem]         [3 elem]         [3 elem]         [3 elem]           1.439e-05 (0.00%)  ** CHANGED **
PE plasma energy                              3.320677e+00     3.320677e+00     3.321293e+00     3.321293e+00       1.618e-09 (0.00%)  ** CHANGED **
PE surface energy                             5.509018e+00     5.509018e+00     5.522422e+00     5.522422e+00       2.245e-07 (0.00%)  ** CHANGED **
PE toroidal torque                            1.119450e-04     1.119448e-04     9.084483e-07     9.084353e-07       1.305e-11 (0.00%)  ** CHANGED **
Summary (last vs prev): 31 changed, 22 unchanged
Case: solovev_kinetic_ntv — Solovev analytical equilibrium, n=1, ideal + PE + NTV torque quadrature
Quantity                                   test/fi18-dev  test/fi20-532  test/fi18-555  test/fi20-532-555  Δ prev             Status       
NTV torque fgar [Re, Im]                   [1 elem]       [1 elem]       [1 elem]       [1 elem]           2.977e-05 (0.00%)  ** CHANGED **
root-area-weighted total energy Re(et[1])  1.090570e-02   1.090571e-02   7.362674e-03   7.362711e-03       3.690e-08 (0.00%)  ** CHANGED **
q0                                         1.900006e+00   1.900006e+00   1.900006e+00   1.900006e+00       4.441e-16 (0.00%)  ** CHANGED **
Summary (last vs prev): 3 changed, 3 unchanged
Case: diiid_n1_riccati — DIII-D-like equilibrium, n=1, Riccati integrator Δ' matrix
Quantity                       test/fi18-dev  test/fi20-532  test/fi18-555  test/fi20-532-555  Δ prev             Status       
delta prime (BVP diagonal)     [5 elem]       [5 elem]       [5 elem]       [5 elem]           3.439e+00 (0.15%)  ** CHANGED **
delta prime (raw side-major)   [10 elem]      [10 elem]      [10 elem]      [10 elem]          2.341e+00 (0.03%)  ** CHANGED **
edge coil response delta_coil  [10 elem]      [10 elem]      [10 elem]      [10 elem]          3.397e-04 (0.00%)  ** CHANGED **
total energy Re(et[1])         8.031975e-01   8.031977e-01   8.031975e-01   8.031977e-01       2.070e-07 (0.00%)  ** CHANGED **
plasma energy Re(ep[1])        -1.368534e+00  -1.368533e+00  -1.368534e+00  -1.368533e+00      7.457e-07 (0.00%)  ** CHANGED **
vacuum energy Re(ev[1])        2.171731e+00   2.171731e+00   2.171731e+00   2.171731e+00       5.387e-07 (0.00%)  ** CHANGED **
total energy (all)             [35 elem]      [35 elem]      [35 elem]      [35 elem]          2.132e-04 (0.00%)  ** CHANGED **
ODE steps (total)              2663           2641           2663           2641               2.200e+01 (0.83%)  ** CHANGED **
q0                             1.204212e+00   1.204212e+00   1.204212e+00   1.204212e+00       2.097e-10 (0.00%)  ** CHANGED **
q95                            4.781723e+00   4.781723e+00   4.781723e+00   4.781723e+00       2.143e-09 (0.00%)  ** CHANGED **
beta_n                         1.372511e+00   1.372511e+00   1.372511e+00   1.372511e+00       5.561e-08 (0.00%)  ** CHANGED **
Summary (last vs prev): 11 changed, 6 unchanged
Case: solovev_kinetic_multiion — Solovev n=1, ideal + PE + multi-ion NTV (D + T + electron summed)
Quantity                     test/fi18-dev  test/fi20-532  test/fi18-555  test/fi20-532-555  Δ prev             Status       
NTV total (D+T+imp+e) [N·m]  2.978404e-01   2.978382e-01   6.534364e-01   6.534112e-01       2.521e-05 (0.00%)  ** CHANGED **
NTV Deuterium [N·m]          1.874428e-01   1.874415e-01   4.112104e-01   4.111956e-01       1.489e-05 (0.00%)  ** CHANGED **
NTV Tritium [N·m]            1.943137e-01   1.943124e-01   4.262844e-01   4.262690e-01       1.535e-05 (0.00%)  ** CHANGED **
NTV electron [N·m]           -8.391612e-02  -8.391569e-02  -1.840584e-01  -1.840533e-01      5.027e-06 (0.00%)  ** CHANGED **
total energy Re(et[1])       1.090570e-02   1.090571e-02   7.362674e-03   7.362711e-03       3.690e-08 (0.00%)  ** CHANGED **
Summary (last vs prev): 5 changed, 1 unchanged
Case: diiid_multi_n — DIII-D-like equilibrium, n = 1, 2, ideal + perturbed equilibrium
Quantity                                                      test/fi18-dev    test/fi20-532    test/fi18-555    test/fi20-532-555  Δ prev             Status       
total energy Re(et[1])                                        -5.750527e-01    -5.750527e-01    -5.750944e-01    -5.750944e-01      1.087e-09 (0.00%)  ** CHANGED **
total energy (all)                                            [58 elem]        [58 elem]        [58 elem]        [58 elem]          9.925e-08 (0.00%)  ** CHANGED **
ODE steps (saved)                                             628              641              913              898                1.500e+01 (1.64%)  ** CHANGED **
permeability diagonal P~_ii (all n blocks)                    [58 elem]        [58 elem]        [58 elem]        [58 elem]          1.172e-07 (0.00%)  ** CHANGED **
PE plasma energy (sum over n)                                 2.936745e+00     2.939967e+00     2.936694e+00     2.936694e+00       1.062e-10 (0.00%)  ** CHANGED **
PE surface energy (sum over n)                                3.523659e+00     3.531158e+00     3.523520e+00     3.523520e+00       8.556e-10 (0.00%)  ** CHANGED **
island half-widths per row                                    [7 elem]         [7 elem]         [7 elem]         [7 elem]           6.119e-08 (0.00%)  ** CHANGED **
Chirikov parameter per row                                    [7 elem]         [7 elem]         [7 elem]         [7 elem]           7.033e-07 (0.00%)  ** CHANGED **
Summary (last vs prev): 8 changed, 11 unchanged
Case: efit_fixedbdy_separatrix — Fixed-boundary EFIT (box hugs LCFS), Newton separatrix-find regression
Quantity                    test/fi18-dev  test/fi20-532  test/fi18-555  test/fi20-532-555  Δ prev   Status
Summary (last vs prev): 5 unchanged
Case: diiid_n1_riccati_precompiled — DIII-D-like equilibrium, n=1, Riccati integrator Δ' matrix, precompiled build
Quantity                       test/fi18-dev  test/fi20-532  test/fi18-555  test/fi20-532-555  Δ prev             Status       
delta prime (BVP diagonal)     [5 elem]       [5 elem]       [5 elem]       [5 elem]           3.439e+00 (0.15%)  ** CHANGED **
delta prime (raw side-major)   [10 elem]      [10 elem]      [10 elem]      [10 elem]          2.341e+00 (0.03%)  ** CHANGED **
edge coil response delta_coil  [10 elem]      [10 elem]      [10 elem]      [10 elem]          3.397e-04 (0.00%)  ** CHANGED **
total energy Re(et[1])         8.031975e-01   8.031977e-01   8.031975e-01   8.031977e-01       2.070e-07 (0.00%)  ** CHANGED **
plasma energy Re(ep[1])        -1.368534e+00  -1.368533e+00  -1.368534e+00  -1.368533e+00      7.457e-07 (0.00%)  ** CHANGED **
vacuum energy Re(ev[1])        2.171731e+00   2.171731e+00   2.171731e+00   2.171731e+00       5.387e-07 (0.00%)  ** CHANGED **
total energy (all)             [35 elem]      [35 elem]      [35 elem]      [35 elem]          2.132e-04 (0.00%)  ** CHANGED **
ODE steps (total)              2663           2641           2663           2641               2.200e+01 (0.83%)  ** CHANGED **
q0                             1.204212e+00   1.204212e+00   1.204212e+00   1.204212e+00       2.097e-10 (0.00%)  ** CHANGED **
q95                            4.781723e+00   4.781723e+00   4.781723e+00   4.781723e+00       2.143e-09 (0.00%)  ** CHANGED **
beta_n                         1.372511e+00   1.372511e+00   1.372511e+00   1.372511e+00       5.561e-08 (0.00%)  ** CHANGED **
Summary (last vs prev): 11 changed, 6 unchanged

Notes for reviewers

The CI manifests in ci/manifests/ are the fully regenerated resolves (067f6d20e), not a one-package pin.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VdRsGGg4YRG6E9fgLGbpdF

@github-actions github-actions Bot added bugfix Something was wrong and now is not changed-results Results move or an interface breaks - read before upgrading labels Oct 16, 2026
@OpenFUSIONToolkit OpenFUSIONToolkit deleted a comment from github-actions Bot Oct 16, 2026
@matt-pharr matt-pharr mentioned this pull request Oct 16, 2026
Closed
@matt-pharr matt-pharr added this to the GPEC v2.0.0 milestone Oct 16, 2026
@logan-nc
logan-nc marked this pull request as ready for review October 23, 2026 05:48
@logan-nc
logan-nc self-requested a review October 23, 2026 05:48
@logan-nc logan-nc self-assigned this Oct 23, 2026
logan-nc and others added 3 commits October 23, 2026 01:51
@logan-nc
Merge remote-tracking branch 'origin/develop' into bugfix/fastinterpo…
c563581 
…lations-0.4.20
@logan-nc @claude
Build - MINOR - Pin only the FastInterpolations bump in the CI manifests
8a4813a 
Restore develop's pins for every other package so the PR moves exactly one dependency.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VdRsGGg4YRG6E9fgLGbpdF
@logan-nc @claude
Build - MINOR - Restore the fully regenerated CI manifests
067f6d2 
Reverts 8a4813a: take the full update.jl resolve, not only the FastInterpolations bump.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VdRsGGg4YRG6E9fgLGbpdF
logan-nc
logan-nc reviewed Oct 23, 2026
View reviewed changes

@logan-nc logan-nc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on behalf of @logan-nc. This is a comment review; the approval stays with a human reviewer.

The numbers look fine. I ran the regression harness on a 2×2 grid: FastInterpolations 0.4.18 or 0.4.20, each with and without #555. The full report is in the PR body.

  • The bump moves Solovev energies by about 2e-4 relative and DIII-D-like energies by under 1e-6.
  • The Riccati Δ′ diagonal moves by up to 0.15%, SLAYER γ by up to 0.07%, and ODE step counts by under 1%.
  • Geometry scalars agree to 1e-7 or better.
  • The bump causes the same moves with and without #555, so the two PRs don't interact and can merge in either order.

Manifests. 067f6d20e restores the fully regenerated ci/manifests/ resolves, as CLAUDE.md asks after a [compat] change. Both runtests jobs pass on them.

PR body. I added the ## Release note block with the harness stamp at 067f6d20e, so the "Title and release note" check should now pass once it reruns. I also removed the "This is a draft" line, since #525 is closed.

Nothing blocking from my side.

@logan-nc
logan-nc enabled auto-merge October 24, 2026 05:37
@logan-nc
logan-nc merged commit 079d7bd into develop Oct 24, 2026
9 checks passed
@logan-nc
logan-nc deleted the bugfix/fastinterpolations-0.4.20 branch October 24, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@logan-nc logan-nc logan-nc approved these changes

Assignees

@logan-nc logan-nc

Labels

bugfix Something was wrong and now is not changed-results Results move or an interface breaks - read before upgrading

Projects

None yet

Milestone

GPEC v2.0.0

Development

Successfully merging this pull request may close these issues.

Build - Bump FastInterpolations.jl to v0.4.20 for PeriodicBC fix

2 participants

@matt-pharr @logan-nc