Add new module Measurement Data #299#313
Open
Ludee wants to merge 16 commits into
Open
Conversation
Member
Author
|
This module is ready for implementation. Please review @Cpprentice |
Cpprentice
requested changes
Jun 16, 2026
Cpprentice
left a comment
There was a problem hiding this comment.
Okay so first, this pull request contains a ton of changes that are not related to new modules and it further combines the changes for the module energy system and measurement data at many places.
I only focussed on the changes related to the measurement module.
Here are the things I found:
- CHANGELOG.md: the Changelog does not yet contain the addition of the measurement module
- oemetadata/v2/v21/metadata_key_details.md: the ontology classes are missing for the new properties - Do we use the predicates from the context json here?
- docs/oemetadata/metadata_key_description.md: same applies here
- docs/oemetadata/metadata_key_details.md: Does not have the keys for the measurement module yet
- oemetadata/v2/v21/metadata_key_details.md, oemetadata/v2/v21/metadata_key_description.md, docs/oemetadata/metadata_key_description.md, and oemetadata/v2/v21/build_source/schemas/module_measurement_data.json: The metadata key descriptions in v21 still use the required cardinality for moduleDescription and instrumentIdentifier. In my Opinion we should add least keep the moduleDescription as required if the module is used. The instrumentIdentifier can be optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
Add metadata keys for module section Measurement Data.
Type of change (CHANGELOG.md)
Added
Measurement Datafor dataset (#313)Workflow checklist
Automation
Closes #299
PR-Assignee
Reviewer