Skip to content

Add new module Measurement Data #299#313

Open
Ludee wants to merge 16 commits into
developfrom
feature-299-module-measurements
Open

Add new module Measurement Data #299#313
Ludee wants to merge 16 commits into
developfrom
feature-299-module-measurements

Conversation

@Ludee

@Ludee Ludee commented May 10, 2026

Copy link
Copy Markdown
Member

Summary of the discussion

Add metadata keys for module section Measurement Data.

Type of change (CHANGELOG.md)

Added

  • Add a module Measurement Data for dataset (#313)

Workflow checklist

Automation

Closes #299

PR-Assignee

  • 🐙 Follow the workflow in CONTRIBUTING.md
  • 📝 Update the CHANGELOG.md
  • 📙 Update the documentation
  • 🐙 Assign a reviewer to the PR

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee self-assigned this May 10, 2026
@Ludee Ludee added priority: critical 🔥 Critical priority part: backend 🧱 Backend component type: feature 🛠 New feature or request status: active 🚧 Work in progress labels May 10, 2026
@Ludee Ludee marked this pull request as ready for review June 11, 2026 13:31
@Ludee Ludee requested review from Cpprentice and jh-RLI June 11, 2026 13:32
@Ludee

Ludee commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

This module is ready for implementation. Please review @Cpprentice

@Cpprentice Cpprentice left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay so first, this pull request contains a ton of changes that are not related to new modules and it further combines the changes for the module energy system and measurement data at many places.
I only focussed on the changes related to the measurement module.

Here are the things I found:

  • CHANGELOG.md: the Changelog does not yet contain the addition of the measurement module
  • oemetadata/v2/v21/metadata_key_details.md: the ontology classes are missing for the new properties - Do we use the predicates from the context json here?
  • docs/oemetadata/metadata_key_description.md: same applies here
  • docs/oemetadata/metadata_key_details.md: Does not have the keys for the measurement module yet
  • oemetadata/v2/v21/metadata_key_details.md, oemetadata/v2/v21/metadata_key_description.md, docs/oemetadata/metadata_key_description.md, and oemetadata/v2/v21/build_source/schemas/module_measurement_data.json: The metadata key descriptions in v21 still use the required cardinality for moduleDescription and instrumentIdentifier. In my Opinion we should add least keep the moduleDescription as required if the module is used. The instrumentIdentifier can be optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part: backend 🧱 Backend component priority: critical 🔥 Critical priority status: active 🚧 Work in progress type: feature 🛠 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add OEMetadata Module - Measurement Data

2 participants