Issue 1473 Translate Improvements#1642
Conversation
huss
left a comment
huss
left a comment
There was a problem hiding this comment.
@Nespina24 Thank you for this contribution. Overall, it works well and is good. I have made a few comments to consider. Please let me know if you have any thoughts/questions.
|
@huss I was unaware about leaving untranslated strings with an emoji. I had them auto-translated by AI at first, but I personally cannot read the automated translations, so I reverted them to the same as the English strings and put the symbol at the end. For the |
huss
left a comment
huss
left a comment
There was a problem hiding this comment.
@Nespina24 During a sweep of PRs today I realized this was ready for re-review but I had not done that. I'm sorry this sat for a while.
Thank you for addressing my previous comments. This seems to be working well. I made two minor comments to consider. I think this is very close to merging. Please let me know if anything is not clear or you have questions/thoughts.
| "compare.line.original.shifted.count.first": "The original line has ", | ||
| "compare.line.original.shifted.count.second": " readings but the shifted line has ", | ||
| "compare.line.original.shifted.count.third": ", which means the points will not align horizontally.", | ||
| "compare.line.shifted.overlaps.start": "The shifted line overlaps the original line starting at {start}", |
| "select.unit": "Select Unit", | ||
| "shift.date.interval": "Shift Date Interval", | ||
| "shifted": "Shifted", | ||
| "shifted.data.crosses.leap.year.to.non.leap.year": "Shifted data crosses a leap year so the graph might not align appropriately", |
2 participants
Description
Translated 6 strings in src/client/app/components/CompareLineChartComponent.tsx, shown below:
Added the necessary key/value translations in src/client/app/translations/data.ts in English, Spanish, and French.
Fixes #1473
Type of change
Checklist
Limitations
The line "const translate = useTranslate();" is used on both line 30 and line 198 in different functions, which feels redundant and a better way might exist.