Rate Testing#1605
Conversation
|
This is to note that PR #1593 may change the route location of the login and this could impact this PR. OED really should check all route names to verify they are correct compared to usage here and the upcoming test code (this part is outside the scope of the PR). |
huss
left a comment
huss
left a comment
There was a problem hiding this comment.
@Zach-O-Bates Thanks for working on this issue. Overall it is okay but I've made some comments to consider. Please let me know if anything is not clear or you have questions/thoughts.
| }); | ||
| expect(first).to.have.status(401); | ||
|
|
||
| const second = await chai.request(app) |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
huss
left a comment
huss
left a comment
There was a problem hiding this comment.
@Zach-O-Bates Thank you for addressing my previous comments. I have made a couple of new ones and also commented on a couple of older ones. I think this is getting much closer. Please let me know if anything is not clear or you have thoughts/questions.
| }); | ||
|
|
||
| //First request that makes it through to authentication | ||
| expect(first).to.have.status(HTTP_CODE.UNAUTHORIZED); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@Zach-O-Bates I was sweeping issues and wanted to see if you could give me any information on the status of this work. Thanks. |
|
I'm noting that several outstanding issues/comments are being marked resolved/hidden because they are completed in PR #1670 but they were never done in this PR. This is helping track needed changes. |
|
PR #1670 continues this work so this PR is being closed since that PR has now addressed all the open comments in this PR. |
2 participants
Description
This pull request resolves issues with login rate limiting and test reliability. The login rate limiter was updated to behave differently based on environment variables, allowing normal tests to run without interference while enforcing strict limits during dedicated rate limit testing. A separate ratetest environment was introduced to properly validate 429 responses without impacting other test suites.
Fixes #1564
Type of change
(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])
Checklist
Limitations
N/A