Skip to content

FW: timestamp of created at for files not global time#206

Merged
TobiasRoeddiger merged 3 commits into
2.2.4from
fix/logfile-timestamps
Jul 1, 2026
Merged

FW: timestamp of created at for files not global time#206
TobiasRoeddiger merged 3 commits into
2.2.4from
fix/logfile-timestamps

Conversation

@habibialireza

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

Copy link
Copy Markdown

Build output available:
openearable_v2_firmware.elf.zip
openearable_v2_fota.zip

@TobiasRoeddiger TobiasRoeddiger linked an issue Jun 8, 2026 that may be closed by this pull request
@DennisMoschina DennisMoschina changed the base branch from main to 2.2.4 June 16, 2026 10:34
@DennisMoschina DennisMoschina force-pushed the fix/logfile-timestamps branch from 80b9c50 to 5d332f1 Compare June 16, 2026 10:34
@github-actions

Copy link
Copy Markdown

Build output available:
openearable_v2_firmware.elf.zip
openearable_v2_fota.zip

@github-actions

Copy link
Copy Markdown

Build output available:
openearable_v2_firmware.elf.zip
openearable_v2_fota.zip

@Ruben-Lohberg Ruben-Lohberg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, but I would really like an explanation on the fallback time being 2022

The remaining comments I left do not regard functionality, see them as recommendations.

Maybe some documentation inside fatfs_time.c could generally help transporting your intent. I now understand that we need this functionality of converting fatfs timestamps because they follow a prorietary fatfs standard and there is no conversion support for that in time.h or elsewhere in our toolchain

Comment thread src/SD_Card/SD_Card_Manager/fatfs_time.c Outdated
Comment thread src/SD_Card/SD_Card_Manager/fatfs_time.c
Comment thread src/SD_Card/SD_Card_Manager/fatfs_time.c Outdated
@github-actions

Copy link
Copy Markdown

Build output available:
openearable_v2_firmware.elf.zip
openearable_v2_fota.zip

@Ruben-Lohberg Ruben-Lohberg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TobiasRoeddiger TobiasRoeddiger merged commit e614f01 into 2.2.4 Jul 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FW: timestamp of created at for files not global time

4 participants