Skip to content

Use default case for Unit methods#3753

Open
simon-lgb wants to merge 1 commit into
OpenEMS:developfrom
ses-systeme:unit-default-case
Open

Use default case for Unit methods#3753
simon-lgb wants to merge 1 commit into
OpenEMS:developfrom
ses-systeme:unit-default-case

Conversation

@simon-lgb

Copy link
Copy Markdown
Contributor

These long lists of all units are difficult to read and frequently cause merge conflicts with some custom units we have in our fork.

While using a default case can generally lead to unhandled enum constants when refactoring, it seems appropriate in these instances where this clearly should be the default behavior for new units.

@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3753      +/-   ##
=============================================
- Coverage      60.61%   60.57%   -0.04%     
  Complexity       105      105              
=============================================
  Files           3356     3356              
  Lines         146350   146350              
  Branches       10852    10852              
=============================================
- Hits           88701    88637      -64     
- Misses         54313    54383      +70     
+ Partials        3336     3330       -6     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant