refs #1 - update abort method on MQHandler requests#15
Open
pccosta-pdm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As descripted in issue:
The pull request suggests the update below while maintaining compatibility with existing functions in public methods and addressing issues related to aborting the request.
W3CDID:
MQHandler:
abortControllerparameter, which is passed throughout the request chain. This allows for aborting the operation at any stage of message processing.stopReceivingMessagesparameter before calling a new method or processing. For safety, request abortion is also verified.PollRequestManager:
createPollingTaskmethod has been changed to return a promise instead of using thesetExecutormethod of the Request function and afterwards using the "executers register"(promiseHandlers) to deal with the response. This allows the removal ofresolveandrejectmethods of the Request functionexecutemethod in the "Request" has been updated to include an abortController in request options.