Repository navigation
OpenConceptLab/ocl_online#517 | exact group-name matching - #66
Merged
Merged
Conversation
hasAuthGroup matched by substring, so `pro` would match `mapper-approved`. It now matches the group name exactly. canSwitchServer checks the three server groups by name, which keeps its current behaviour. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
oclweb3 doesn't use the server groups; server switching is a legacy oclweb2 feature. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This was referenced Oct 16, 2026
snyaggarwal
commented
Oct 16, 2026
snyaggarwal
left a comment
snyaggarwal
left a comment
Contributor
Author
There was a problem hiding this comment.
Verdict: Approve
The exact group-name change satisfies the oclweb3 portion of OpenConceptLab/ocl_online#517. The live callers pass complete names (mapper-approved, core_user, and operations_panel), and the removed canSwitchServer export has no callers in this repository.
Verification: full npm run eslint passes; PR ESLint and Snyk checks are green. This repository has no unit-test script.
Security blockers: none.
GitHub does not allow authors to formally approve their own PR, so this verdict is posted as a review comment.
(snyaggarwal • Codex/GPT-5)
paynejd
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref OpenConceptLab/ocl_online#517
hasAuthGroupmatched group names by substring, so a check for one group was also true for any group whose name contained it:servermatchedocl_servers. It now matches exactly. The unusedcanSwitchServerhelper and its server-group check are removed, since server switching is a legacy oclweb2 feature.Lint passes. This repo has no unit test script, and I haven't checked the UI in a browser.
🤖 Generated with Claude Code