Repository navigation
OpenConceptLab/ocl_online#504 | A profile slot under the username for the private UI package - #65
Conversation
…for a component from the private UI package loadUserProfileExtension() loads UserProfileExtension from the optional ocl-analytics-web package, as loadUsageDashboard() does; without the package the stub's null renders nothing. UserProfile renders it under the username with the profile's user, the current user, APIService and the analytics URL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codex review, pass 1 (codex-cli 0.163.0, commit 0b8bbf5) Verdict: clean. No findings. findings.json{
"reviewer": "codex-cli 0.163.0",
"perspective": "defects",
"mode": "full",
"commit": "0b8bbf56",
"verdict": "clean",
"prior": [],
"findings": []
} |
|
Simplification review (Claude subagent, commit 0b8bbf5)
No cuts applied, so no commits after the Codex pass and no follow-up check. |
snyaggarwal
left a comment
There was a problem hiding this comment.
Reviewed together with OpenConceptLab/ocl-analytics-web#3 against OpenConceptLab/ocl_online#504.
Verdict: approve — no blocking findings.
The public host adds an inert slot when the private package is absent, passes the expected user/current-user/API/i18n/analytics adapters when present, and preserves the existing usage-dashboard integration. The translations cover every key consumed by the private card. I also verified ESLint and a production webpack build with the PR version of ocl-analytics-web installed.
Coverage gap: the new loader/profile-extension path has no automated test, so the optional-package and visibility behavior is currently protected by manual/integration checks only. Ticket-level production checks with the paid Pro and Community accounts remain outstanding outside this PR.
Merge after OpenConceptLab/ocl-analytics-web#3 so the private package export exists when TBv3 is rebuilt.
Part of OpenConceptLab/ocl_online#504.
Adds a slot under the username on the user profile for a component from the optional private UI package, the same way the usage dashboard is loaded today.
loadUserProfileExtension()insrc/common/plugins/loader.jsreturns the package'sUserProfileExtension, ornull.UserProfileExtension = null, so a build without the package renders nothing and nothing changes.UserProfile.jsxrenders it under the username withuser,currentUser,APIServiceand the analytics URL.Checked: CI's ESLint command passes. Locally, the profile renders unchanged with the stub, and renders the package's component when it's installed.
🤖 Generated with Claude Code