Repository navigation
OpenConceptLab/ocl_issues#2902 | Load the Locales catalog from the cached lookup endpoint - #99
Merged
Conversation
…ched lookup endpoint fetchOclLocales listed /orgs/OCL/sources/Locales/concepts/?limit=500 on every project open: 486 full rows, 421 KB, about 6 s in production. The lookup endpoint returns the same 184 locale/display_name pairs in 56 KB and about 0.3 s, and the API caches it for 24 hours, as fetchMapTypes already uses. closes OpenConceptLab/ocl_issues#2902 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
Codex review, pass 1 (codex-cli 0.162.1, commit 1c307bf)Verdict: clean. No findings. findings.json{
"reviewer": "codex-cli 0.162.1",
"perspective": "defects",
"mode": "full",
"commit": "1c307bf06583e7ebc2ba88b8c483a578a25a21dc",
"verdict": "clean",
"prior": [],
"findings": []
} |
Member
Author
|
Simplification review (fresh Claude subagent, commit 1c307bf): clean, nothing to cut. Review loop done: Codex pass 1 clean, so no further passes. |
snyaggarwal
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes OpenConceptLab/ocl_issues#2902
The Mapper now loads its locale catalog from
/orgs/OCL/sources/Locales/concepts/lookup/?verbose=trueinstead of/orgs/OCL/sources/Locales/concepts/?limit=500.fetchMapTypesalready reads map types the same way.The lookup endpoint has no
retiredfield, so I dropped the!c?.retiredfilter.OCL/Localeshas no retired concepts.Testing: ran CI's lint and
npm run test:all; both pass. I compared the two production responses directly and didn't run the app.🤖 Generated with Claude Code