Skip to content

OpenConceptLab/ocl_issues#2872 | auto match should not run when no algos are configured and/or without any existing candidates #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snyaggarwal merged 4 commits into from
Oct 6, 2026
Merged

OpenConceptLab/ocl_issues#2872 | auto match should not run when no algos are configured and/or without any existing candidates #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c96eaf
OpenConceptLab/ocl_issues#2872 | auto match should not run when algos…
snyaggarwal Oct 5, 2026
87c9775
OpenConceptLab/ocl_issues#2872 | review feedbacks
snyaggarwal Oct 6, 2026
cf9c892
Apply batched suggestions from code review
snyaggarwal Oct 6, 2026
7d31273
Apply batched suggestions from code review
snyaggarwal Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 88 additions & 28 deletions src/components/map-projects/AutoMatchDialog.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import TagCountLabel from '../common/TagCountLabel'
import RepoChip from '../repos/RepoVersionChip'
import AIAssistantSelectorPanel from './AIAssistantSelectorPanel'
import { getMapperPreview } from '../../common/utils'
import { getRowCapByMatchOperations } from './autoMatchRows'
import { getRowCapByMatchOperations, getAutoMatchBlocker } from './autoMatchRows'


const AutoMatchDialog = ({
Expand All @@ -47,12 +47,16 @@ const AutoMatchDialog = ({
onSubmit,
inAIAssistantGroup,
algosSelected,
runnableAlgos,
retrieveCandidates: retrieveCandidatesChecked,
setRetrieveCandidates,
canSelectAIModel,
previewEligibleRowIndexes,
matchAlgorithmIds
matchAlgorithmIds,
aiOnlyRowCounts,
onConfigure
}) => {
const { t } = useTranslation()
const [algos, setAlgos] = React.useState(true)
const [confirmAllIncludingApproved, setConfirmAllIncludingApproved] = React.useState(false)
const previewEligibleRowIndexSet = React.useMemo(
() => Array.isArray(previewEligibleRowIndexes) ? new Set(previewEligibleRowIndexes.map(id => id?.toString())) : null,
Expand Down Expand Up @@ -80,13 +84,19 @@ const AutoMatchDialog = ({
const hasUnmappedRows = unmappedRowsCount > 0
const hasApprovedRows = reviewedRowsCount > 0
const isAllIncludingApproved = autoMatchScope === 'allIncludingApproved'
// Only the algorithms this user can run retrieve candidates (ocl_issues#2872).
const hasAlgorithms = runnableAlgos.length > 0
const retrieveCandidates = retrieveCandidatesChecked && hasAlgorithms
const runAI = Boolean(inAIAssistantGroup && autoRunAIAnalysis)
const isAIOnly = runAI && !retrieveCandidates
const aiRowsToAnalyse = isAIOnly ? (aiOnlyRowCounts?.analyse || 0) : 0

// One-time allowance (R2, no reset). Each row costs one match operation per
// selected algorithm that calls $match (TQ6); scispacy, custom algorithms
// with their own url and a bridge the user can't run don't spend any.
const preview = getMapperPreview()
const matchAlgorithmIdSet = React.useMemo(() => new Set(matchAlgorithmIds || []), [matchAlgorithmIds])
const matchAlgorithmCount = algos ? algosSelected.filter(algo => matchAlgorithmIdSet.has(algo.id)).length : 0
const matchAlgorithmCount = retrieveCandidates ? runnableAlgos.filter(algo => matchAlgorithmIdSet.has(algo.id)).length : 0
const operationsRemaining = (preview.matchOperations.unlimited || !matchAlgorithmCount) ? null : preview.matchOperations.remaining
const rowCap = getRowCapByMatchOperations(preview.matchOperations, matchAlgorithmCount)
const willTruncate = rowCap !== null && rowsToMatchCount > rowCap
Expand All @@ -96,7 +106,8 @@ const AutoMatchDialog = ({
// One $invoke per row. The AI quota never caps rows: once it runs out, the
// rest of the run is matched without AI recommendations.
const aiCallsRemaining = preview.aiAssistantCalls.unlimited ? null : preview.aiAssistantCalls.remaining
const aiRowsCovered = (inAIAssistantGroup && autoRunAIAnalysis && aiCallsRemaining !== null) ? Math.min(aiCallsRemaining, rowsThisRun) : null
const aiRows = isAIOnly ? aiRowsToAnalyse : rowsThisRun
const aiRowsCovered = (runAI && aiCallsRemaining !== null) ? Math.min(aiCallsRemaining, aiRows) : null
const getPreviewEstimate = () => {
if(isPreviewQuotaExhausted)
return t('map_project.preview_estimate_no_operations_left')
Expand All @@ -113,15 +124,17 @@ const AutoMatchDialog = ({
allowed: rowsThisRun.toLocaleString(),
requested: rowsToMatchCount.toLocaleString()
}))
if(aiRowsCovered !== null) {
if(aiRowsCovered >= rowsThisRun)
parts.push(t('map_project.preview_estimate_ai_all', {count: rowsThisRun.toLocaleString()}))
else if(aiRowsCovered === 0)
parts.push(t('map_project.preview_estimate_ai_none'))
if(aiRowsCovered !== null && aiRows > 0) {
if(aiRowsCovered >= aiRows)
parts.push(t('map_project.preview_estimate_ai_all', {count: aiRows.toLocaleString()}))
else if(aiRowsCovered === 0) {
if(!isAIOnly)
parts.push(t('map_project.preview_estimate_ai_none'))
}
else
parts.push(t('map_project.preview_estimate_ai_partial', {
parts.push(t(isAIOnly ? 'map_project.preview_estimate_ai_only_partial' : 'map_project.preview_estimate_ai_partial', {
covered: aiRowsCovered.toLocaleString(),
rest: (rowsThisRun - aiRowsCovered).toLocaleString()
rest: (aiRows - aiRowsCovered).toLocaleString()
}))
}
return parts.join(' ')
Expand Down Expand Up @@ -182,11 +195,26 @@ const AutoMatchDialog = ({
}
]

const blocker = getAutoMatchBlocker({
rowsInScope: rowsToMatchCount,
hasAlgorithms,
retrieveCandidates,
runAI,
aiRowsToAnalyse,
aiCallsRemaining
})
const blockerMessages = {
no_rows: t('map_project.auto_match_blocked_no_rows'),
no_algorithms: t(inAIAssistantGroup ? 'map_project.auto_match_blocked_no_algorithms_ai' : 'map_project.auto_match_blocked_no_algorithms'),
no_step: t(inAIAssistantGroup ? 'map_project.auto_match_blocked_no_step_ai' : 'map_project.auto_match_blocked_no_step'),
no_ai_rows: t('map_project.auto_match_blocked_no_ai_rows'),
no_ai_calls: t('map_project.auto_match_blocked_no_ai_calls'),
}

const isDisabled =
!repoVersion?.version_url ||
rowsToMatchCount === 0 ||
Boolean(blocker) ||
isPreviewQuotaExhausted ||
(!algos && !autoRunAIAnalysis) ||
(isAllIncludingApproved && !confirmAllIncludingApproved)

return (
Expand Down Expand Up @@ -266,19 +294,36 @@ const AutoMatchDialog = ({
</FormControl>

<FormControl sx={{marginTop: '8px'}}>
<FormControlLabel control={<Checkbox checked={algos} onChange={() => setAlgos(!algos)} />} label={t('map_project.retrieve_candidates')} />
<FormLabel id="algorithms" sx={{marginTop: '-4px', marginLeft: '12px'}}>
{t('map_project.retrieve_candidates_helper_text')}
</FormLabel>
<div className='col-xs-12 padding-0' style={{marginLeft: '8px'}}>
{
algosSelected.map(algo => {
return (
<Chip variant='outlined' size='small' color='warning' label={algo.id} key={algo.id} sx={{margin: '4px'}} />
)
})
}
</div>
<FormControlLabel control={<Checkbox checked={retrieveCandidates} disabled={!hasAlgorithms} onChange={event => setRetrieveCandidates(event.target.checked)} />} label={t('map_project.retrieve_candidates')} />
{
hasAlgorithms ?
<>
<FormLabel id="algorithms" sx={{marginTop: '-4px', marginLeft: '12px'}}>
{t('map_project.retrieve_candidates_helper_text')}
</FormLabel>
<div className='col-xs-12 padding-0' style={{marginLeft: '8px'}}>
{
runnableAlgos.map(algo => {
return (
<Chip variant='outlined' size='small' color='warning' label={algo.id} key={algo.id} sx={{margin: '4px'}} />
)
})
}
</div>
</> :
<Alert
severity='warning'
sx={{marginTop: '4px', marginLeft: '12px'}}
action={
onConfigure &&
<Button variant='contained' color='primary' size='small' sx={{textTransform: 'none', whiteSpace: 'nowrap'}} onClick={onConfigure}>
{t('map_project.auto_match_configure_algorithms')}
</Button>
}
>
{t(algosSelected.length ? 'map_project.auto_match_no_runnable_algorithms' : 'map_project.auto_match_no_algorithms')}
</Alert>
}
</FormControl>

{
Expand All @@ -299,6 +344,15 @@ const AutoMatchDialog = ({
<FormHelperText sx={{marginTop: '-4px'}}>
{t('map_project.run_ai_analysis_note')}
</FormHelperText>
{
isAIOnly && rowsToMatchCount > 0 && aiOnlyRowCounts &&
<Alert severity={aiRowsToAnalyse ? 'info' : 'warning'} sx={{marginTop: '8px'}}>
{t('map_project.auto_match_ai_only_rows', {
analyse: aiOnlyRowCounts.analyse.toLocaleString(),
skip: aiOnlyRowCounts.skip.toLocaleString()
})}
</Alert>
}
{
autoRunAIAnalysis && canSelectAIModel &&
<AIAssistantSelectorPanel
Expand All @@ -315,13 +369,19 @@ const AutoMatchDialog = ({
}
</DialogContent>
<DialogActions sx={{padding: '16px'}}>
{
blocker &&
<FormHelperText sx={{margin: 0, color: 'warning.main'}}>
{blockerMessages[blocker]}
</FormHelperText>
}
<Button
variant='contained'
size='small'
sx={{textTransform: 'none', marginLeft: '12px'}}
endIcon={<DoubleArrowIcon />}
disabled={isDisabled}
onClick={event => onSubmit(event, algos ? map(algosSelected, val => val?.id) : [])}
onClick={event => onSubmit(event, retrieveCandidates ? map(runnableAlgos, val => val?.id) : [])}
>
{t('common.submit')}
</Button>
Expand Down
Loading
Loading