Repository navigation
OpenConceptLab/ocl_issues#2878 | Localization guide + cross-language glossary of OCL terms - #13
Conversation
…les and cross-language glossary of OCL terms Adds guides/localization.html (static page) with: - rules for developers so translated text still reads correctly once code assembles it - rules for translators (resource-name rule, never-translate list, OCL AI Assistant naming) - a glossary of canonical OCL terms in es, zh and pt-BR, pulled from the app catalogs, with open pt-BR decisions marked for the pt-BR translation lead Links it from the overview, the README and the Building Pages i18n section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… apps, note app differences, base-term convention, AI naming exceptions Addresses Codex review pass 1 on ocl-design-system#13. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
paynejd
left a comment
There was a problem hiding this comment.
Codex adversarial review, pass 1 (codex-cli 0.160.0, commit 8b27212). All five findings were addressed in 3d3c95d.
Findings
-
public/guides/localization.html:108,112,117,124,127 — Catalog capitalization differs. Use pt-BR
Classe do Conceito,Não Publicado,URL Canônica, andRepositório de Destino; SpanishAlgoritmo de CoincidenciaandRepositorio Objetivo. These are the corresponding catalog labels. Confidence: high. -
public/guides/localization.html:115,117,119,120 — Several dashes incorrectly imply missing translations. Locale has Spanish
Idiomain oclweb3 andConfiguración regionalin oclmap. Canonical URL has SpanishURL canónicaand Chinese规范型 URL(also规范 URLfor the Mapper algorithm label). Mapper Delete hasEliminar/删除. Collection Include has Chinese包含;common.excludehas排除, althoughreference.excludeis missing. Fix: identify app/key differences explicitly instead of using blanket dashes. Confidence: high. -
public/guides/localization.html:122,123,126,128,130,131 — Some purported catalog values are inferred terms, not complete catalog strings. Spanish/pt-BR singular Mapping project and Candidate, Spanish/Chinese standalone Match, all standalone Quota/Allowance values, and bare
Bridgedo not occur as exact catalog values. For example, the catalogs containProyectos de Mapeo,Candidatos, andBridge:; Chinesebridge_canonical_shortis桥接:. Fix: distinguish extracted/proposed terminology from verbatim catalog labels and cite the source keys. Confidence: high. -
public/guides/localization.html:89 — “OCL never says ‘AI recommendations’” contradicts existing copy. Mapper’s
preview_estimate_ai_allandpreview_estimate_ai_partialexplicitly use “AI recommendations”; pt-BRpreview_quota_ai_callsalso usesChamadas do Assistente de IAwithout OCL. Fix: describe this as the intended naming rule and flag existing exceptions. Confidence: high. -
public/guides/localization.html:130 — Quota is defined too narrowly. The apps also implement one-time preview quotas (
quota.period_one_time,preview_quota_tooltip_title). Fix: say an allowance can be recurring or one-time. Confidence: high.
Checked and fine
- Compared both apps’ English/Spanish/Chinese catalogs at
origin/mainand pt-BR atHEAD; remaining glossary labels match, with HEAD appropriately treated as a literal identifier. - Escape configuration claim is correct; English fallback and the Chinese catalog/menu distinction are correct.
- New relative links and guide assets resolve correctly beneath
/ocl-design-system/; README’s source link is valid. - All 13 JSX page entries compiled and bundled in memory with zero errors.
git diff --checkpassed. Full Vite build was not run because it writes files. - No secrets or obvious sensitive information found. No files modified.
paynejd
left a comment
There was a problem hiding this comment.
Codex adversarial review, pass 2 (codex-cli 0.160.0, commit 3d3c95d). Clean.
Reviewed 3d3c95d and the full page against both apps’ catalogs: en/es/zh at origin/main, pt-BR at HEAD.
| Pass-1 finding | Status |
|---|---|
| Catalog capitalization differs | RESOLVED — glossary now explicitly normalizes terms to sentence case. |
| Dashes incorrectly imply missing translations | RESOLVED — missing values filled; Spanish Locale and Chinese Canonical URL differences documented. |
| Inferred terms presented as exact catalog strings | RESOLVED — introduction identifies entries as normalized base terms rather than verbatim labels. |
| AI naming rule contradicts existing copy | RESOLVED — existing Mapper exceptions explicitly acknowledged. |
| Quota defined too narrowly | RESOLVED — definition now includes one-time allowances. |
NEW findings: None.
No files modified.
Part of OpenConceptLab/ocl_issues#2878.
Adds a Localization guide,
guides/localization.html(a static page underpublic/). It came out of the pt-BR translation review in OpenConceptLab/oclweb3#60 and OpenConceptLab/oclmap#90:escapeValuein oclweb3, shared keys kept identical.Also links the guide from the overview, the README and the Building Pages i18n section. That section's language list was out of date; it now includes pt-BR and notes zh isn't in the menu.
Still to do under #2878: link the guide from the oclweb3 and oclmap i18n folders, and an optional catalog check. Both will come once the pt-BR PRs merge.
Verified:
vite buildpasses, and the page renders correctly (checked in headless Chrome).🤖 Generated with Claude Code