Repository navigation
fix(python): restore time import in udp interface tests - #4152
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
UDP test time import openc3/python/test/interfaces/test_udp_interface.py |
The test file imports Python’s time module. |
Priority:
Estimated code review effort: 1 (Trivial) | ~2 minutes
Change: Bug fix
Possibly related PRs
- OpenC3/cosmos#3902: Added UDP read-queue tests in the same file that call
time. - OpenC3/cosmos#4143: Removed the
timeimport from the same file.
Suggested labels: python, testing
Suggested reviewers: jmthomas
Merge Risk: 
Minimal · up to b7ddf
-
This test-only change has no identified merge-blocking risk.
Architecture risk: 
Low · up to b7ddf
-
The change affects 1 system.
Changed systems:
openc3Architecture concerns
No architecture-level concerns identified.Review details
-
Systems and components
- observed — openc3 (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
- observed — Modified behavior in openc3/python/test/interfaces/test_udp_interface.py: Added the
timeimport.
-
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4152 +/- ##
==========================================
- Coverage 81.17% 80.25% -0.92%
==========================================
Files 691 909 +218
Lines 45253 70551 +25298
Branches 2688 2741 +53
==========================================
+ Hits 36733 56623 +19890
- Misses 7843 13252 +5409
+ Partials 677 676 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|



What changed
Restores
import timeinopenc3/python/test/interfaces/test_udp_interface.py.Why it changed
mainhas failed Python unit tests since #3902 merged (c8eb390d3). Two tests fail withNameError: name 'time' is not defined:test_queues_datagrams_as_fast_as_they_arrivetest_limits_how_many_bytes_are_queuede5a6b85 went into
mainon its own and removed the import, which was unused there at the time. The #3902 branch never got that commit, and it added tests that usetime. The merge applied cleanly but left those tests without the import. Any PR whose CI runs against currentmainhits the same failure, PR #3948 for example.Testing strategy
uv run pytest test/interfaces/test_udp_interface.py: 25 passed.ruff checkis clean.🤖 Generated with Claude Code
Summary by CodeRabbit