Repository navigation
build(anycable): install anycable-go only in the API images #4083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1762d5a
build(anycable): install anycable-go only in the API images
EmilyRagan 2dcee41
ci(build-cosmos): hash openc3-anycable into API image cache keys
EmilyRagan 5971595
build(anycable): point update tooling at openc3-anycable
EmilyRagan 8ffb5c6
build(anycable): copy anycable-go by TARGETARCH before API source
jmthomas da53467
Merge pull request #4094 from OpenC3/anycable-api-images-copy
EmilyRagan 8e2e38c
update comments
EmilyRagan e826f7a
Merge branch 'main' into anycable-api-images-only
EmilyRagan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
rg -n 'docker-compose|docker compose|Compose|compose version|compose.*install|install.*compose' docs scripts README.mdRepository: OpenC3/cosmos
Length of output: 45652
🏁 Script executed:
Repository: OpenC3/cosmos
Length of output: 14088
🏁 Script executed:
Repository: OpenC3/cosmos
Length of output: 45660
Require Docker Compose 2.17.0 before the Compose build.
openc3.shacceptsdocker composeanddocker-composewithout checking their versions. The API builds now requireadditional_contexts, which Docker Compose supports only from 2.17.0. An older Compose executable can therefore fail to provide theanycablecontext required byCOPY --from=anycable.Suggested fix
@@ detect_compose_cmd() { @@ export DOCKER_COMPOSE_COMMAND="$CONTAINER_COMPOSE_CMD" } + +check_compose_build_version() { + local version + version=$($CONTAINER_COMPOSE_CMD version --short 2>/dev/null || true) + if [[ ! "$version" =~ (^|[^0-9])([0-9]+)\.([0-9]+)\.([0-9]+) ]] || + (( BASH_REMATCH[2] < 2 )) || + (( BASH_REMATCH[2] == 2 && BASH_REMATCH[3] < 17 )); then + echo "Docker Compose 2.17.0 or later is required to build COSMOS." >&2 + exit 1 + fi +} @@ cd "$(dirname -- "$0")" + check_compose_build_version "$(find_script openc3_setup.sh)" @@ cd "$(dirname -- "$0")" + check_compose_build_version "$(find_script openc3_setup.sh)"🤖 Prompt for AI Agents