Skip to content

fix(docker): improve dockerignore list - #3986

Merged
EmilyRagan merged 2 commits into
mainfrom
dockerignore
Oct 16, 2026
Merged

EmilyRagan merged 2 commits into
mainfrom
dockerignore

Conversation

@EmilyRagan

@EmilyRagan EmilyRagan commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

What changed

Added depth matching to openc3/.dockerignore

Why it changed

  • Python tests (at openc3/python/test) were being copied into the image because the ignore path only matched openc3/test/ -- this was adding ~200 unnecessary files to the published images
  • for local builds, local python/.venv (and other paths) was being copied into the image and overwriting the image's uv-built .venv because the ignore path only matched openc3/.venv -- this is only an improvement/fix/change for locally built images, not published ones

Testing strategy

CI building images

Review notes

It's not that much of an image size change, but it should result in slightly faster local re-builds due to being able to reuse layers more effectively . Compared image sizes locally:

main branch diff
Uncompressed, sum of layer sizes (docker history) 1,679,073,280 B 1,673,703,424 B −5.37 MB (−0.32%)
Uncompressed, files under /openc3 366,994,945 B (10,264 files) 364,851,397 B (10,056 files) −2.14 MB (−208 files)
Compressed (docker image inspect) 584,984,929 B 584,414,301 B −0.57 MB (−0.10%)

Summary by CodeRabbit

  • Chores
    • Docker builds now exclude additional development and generated files, including package artifacts, debug symbols, Python caches, and build outputs. Coverage, test, and spec files are also excluded consistently across nested directories. This keeps unnecessary files out of the build context.

@EmilyRagan EmilyRagan self-assigned this Oct 1, 2026
@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.53%. Comparing base (3ded1cf) to head (ee07116).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3986      +/-   ##
==========================================
- Coverage   80.53%   80.53%   -0.01%     
==========================================
  Files         904      904              
  Lines       68992    68992              
  Branches     2681     2681              
==========================================
- Hits        55565    55563       -2     
+ Misses      12765    12763       -2     
- Partials      662      666       +4     
Flag Coverage Δ
frontend 67.29% <ø> (-0.13%) ⬇️
python 80.52% <ø> (-0.01%) ⬇️
ruby-api 83.05% <ø> (+0.30%) ⬆️
ruby-backend 86.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0c292985-56d7-4bcd-a145-4a69d4497f0e
📥 Commits

Reviewing files that changed from the base of the PR and between 3ded1cf and ee07116.

📒 Files selected for processing: 1
  • openc3/.dockerignore

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The .dockerignore rules now exclude additional artifacts and match coverage, spec, test, and Python exclusions at any directory depth.

Changes: Docker build context exclusions

Layer / File(s) Summary
Expand Docker ignore rules
openc3/.dockerignore
Coverage, spec, test, and Python exclusions now match at any directory depth. The rules also exclude .bundle, .dSYM, *.gem, and python/build/.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: jmthomas

Merge Risk: ⚪ Minimal · up to ee071

The expanded ignore rules remove nested test and development artifacts from local Docker contexts. The inspected build inputs remain available, and no concrete merge-blocking impact was found.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: improving the Docker ignore rules. It is concise and related to the pull request objectives.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@EmilyRagan
EmilyRagan marked this pull request as ready for review October 16, 2026 16:50
@EmilyRagan
EmilyRagan merged commit 222c0b6 into main Oct 16, 2026
37 of 39 checks passed
@EmilyRagan
EmilyRagan deleted the dockerignore branch October 16, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants