Skip to content

Fix iCloud Messages sync by verifying extra TLK share fields - #255

Open
thesacredmoocow wants to merge 1 commit into
OpenBubbles:rustpushfrom
thesacredmoocow:fix/icloud-manatee-tlk-sync
Open

Fix iCloud Messages sync by verifying extra TLK share fields#255
thesacredmoocow wants to merge 1 commit into
OpenBubbles:rustpushfrom
thesacredmoocow:fix/icloud-manatee-tlk-sync

Conversation

@thesacredmoocow

Copy link
Copy Markdown

Summary

  • Bump the rustpush submodule to include extra CloudKit fields when verifying Manatee tlkshare signatures.
  • Fixes iCloud Messages sync getting stuck after Signature verification failed / Bad message during TLK unwrap.
  • Depends on Include extra CloudKit fields in TLK share signature checks rustpush#34 (merge that first so this submodule SHA exists on OpenBubbles/rustpush).

Test plan

  • Merge rustpush PR 34 first, then confirm this submodule pin resolves
  • Sign in with Messages in iCloud enabled
  • Confirm history sync proceeds past encryption-config fetch
  • Confirm no change to uploaded iCloud share/signing traffic

Pin rustpush so iCloud Messages can unwrap shares that now include extra CloudKit fields such as tlkOwnershipProof.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant