Skip to content

Make swallowed message uniqueness failures observable #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Xare123 wants to merge 1 commit into
base: rustpush
Choose a base branch
from
Draft

Make swallowed message uniqueness failures observable #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions lib/database/io/message.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,15 @@ class Message {
try {
if (chat != null) this.chat.target = chat;
id = Database.messages.put(this);
} on UniqueViolationException catch (_) {}
} on UniqueViolationException catch (ex, stack) {
// Still swallowed, because callers rely on save() not throwing. But no
// longer silent: on this path `id` stays null and the message is
// returned as though it had been persisted, so nothing downstream can
// distinguish a saved message from a dropped one. replaceMessage
// already logs this exact constraint below; these two sites did not.
Logger.error('Failed to save message! This is likely due to a unique constraint being violated.',
error: ex, trace: stack);
}
});
return this;
}
Expand Down Expand Up @@ -860,7 +868,13 @@ class Message {
for (int i = 0; i < messages.length; i++) {
messages[i].id = ids[i];
}
} on UniqueViolationException catch (_) {}
} on UniqueViolationException catch (ex, stack) {
// The reaction-linking pass above did not persist. The ids assigned by
// the earlier putMany still stand, so this is narrower than the save()
// case, but it is the same invisible failure and worth seeing.
Logger.error('Failed to bulk save messages! This is likely due to a unique constraint being violated.',
error: ex, trace: stack);
}
});
return messages;
}
Expand Down