Skip to content

[JAVA] Add apache httpcomponts library to java clients - #9985

Closed
harrywhite4 wants to merge 33 commits into
OpenAPITools:masterfrom
atlassian-forks:apache-java-client
Closed

[JAVA] Add apache httpcomponts library to java clients#9985
harrywhite4 wants to merge 33 commits into
OpenAPITools:masterfrom
atlassian-forks:apache-java-client

Conversation

@harrywhite4

Copy link
Copy Markdown

Added the option to generate a java client using the apache httpcomponents library. Have opened against the 5.3.x branch since i thought this would not be part of a patch release, let me know if i need to change that

I did do some testing of the generated code in a separate project, wasn't sure how that could be integrated into the testing of the samples though.

Tech commitee: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @nmuesch

This closes #9866

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Harry White added 30 commits July 20, 2021 18:43
Plus switch to TypeReference to handle generic types
If the method doesn't need to close it
Based on the implementation in the jersey client
Would have had issues with content type headers containing a charset
Otherwise they will be excluded from the request
@wing328

wing328 commented Jul 20, 2021

Copy link
Copy Markdown
Member

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328

wing328 commented Jul 20, 2021

Copy link
Copy Markdown
Member

You can target this change (additional support of HTTP library) to the current master.

@wing328 wing328 added this to the 5.2.1 milestone Jul 20, 2021
@wing328 wing328 modified the milestones: 5.2.1, 5.3.0 Aug 17, 2021
@wing328
wing328 changed the base branch from 5.3.x to master August 21, 2021 14:42
@wing328

wing328 commented Aug 21, 2021

Copy link
Copy Markdown
Member

I've resolved the merge conflicts and filed #10218 instead so closing this one.

@wing328 wing328 closed this Aug 21, 2021
@harrywhite4

Copy link
Copy Markdown
Author

Thanks for cleaning that up, i did use a different email but thats all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] [JAVA] Apache httpcomponents client library

2 participants