[JAVA] Add apache httpcomponts library to java clients - #9985
Closed
harrywhite4 wants to merge 33 commits into
Closed
[JAVA] Add apache httpcomponts library to java clients#9985harrywhite4 wants to merge 33 commits into
harrywhite4 wants to merge 33 commits into
Conversation
added 30 commits
July 20, 2021 18:43
Plus switch to TypeReference to handle generic types
If the method doesn't need to close it
Based on the implementation in the jersey client
Would have had issues with content type headers containing a charset
Otherwise they will be excluded from the request
Member
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
Member
|
You can target this change (additional support of HTTP library) to the current master. |
5 tasks
Member
|
I've resolved the merge conflicts and filed #10218 instead so closing this one. |
Author
|
Thanks for cleaning that up, i did use a different email but thats all good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the option to generate a java client using the apache httpcomponents library. Have opened against the 5.3.x branch since i thought this would not be part of a patch release, let me know if i need to change that
I did do some testing of the generated code in a separate project, wasn't sure how that could be integrated into the testing of the samples though.
Tech commitee: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @nmuesch
This closes #9866
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.3.x,6.0.x