[abstract csharp] Ensure enum dataType is not nullable string - #9891
Merged
Conversation
merge upstream
merge upstream
Contributor
Author
|
circleci failed with |
Member
|
I saw changes to samples (e.g. scala) not related to this change. Can you please merge the latest master your branch and update the samples again? |
Contributor
Author
|
I will do that next week. Im out of town now. |
Contributor
Author
|
@wing328 Done. Edit-oh i specified csharp when building. Ill do again and build all. |
devhl-labs
force-pushed
the
enum-is-string
branch
from
August 3, 2021 23:44
4f68af8 to
66ca36b
Compare
Contributor
Author
|
@wing328 Now it's better. Why does did it take 18 commits to change two files 🤣 |
Member
|
Gradle, maven plugin test failure already fixed in the master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix a case where the enum dataType is string? instead of string resulting in code that does not compile. This simply corrects the dataType.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x@mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti