Skip to content

[abstract csharp] Ensure enum dataType is not nullable string - #9891

Merged
wing328 merged 18 commits into
OpenAPITools:masterfrom
devhl-labs:enum-is-string
Aug 22, 2021
Merged

[abstract csharp] Ensure enum dataType is not nullable string#9891
wing328 merged 18 commits into
OpenAPITools:masterfrom
devhl-labs:enum-is-string

Conversation

@devhl-labs

Copy link
Copy Markdown
Contributor

This will fix a case where the enum dataType is string? instead of string resulting in code that does not compile. This simply corrects the dataType.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti

@devhl-labs

Copy link
Copy Markdown
Contributor Author

circleci failed with 02:53:46.426 [qtp2074407503-16] INFO i.s.sample.resource.PetResource - updatePetWithForm 12830 golang which is not related. AppVeyor failed with Error calling GetPetById: {"code":1,"type":"error","message":"Pet not found"} which I don't see how that can be related.

@wing328

wing328 commented Jul 28, 2021

Copy link
Copy Markdown
Member

I saw changes to samples (e.g. scala) not related to this change.

Can you please merge the latest master your branch and update the samples again?

@devhl-labs

Copy link
Copy Markdown
Contributor Author

I will do that next week. Im out of town now.

@devhl-labs

devhl-labs commented Aug 3, 2021

Copy link
Copy Markdown
Contributor Author

@wing328 Done. Edit-oh i specified csharp when building. Ill do again and build all.

@devhl-labs

Copy link
Copy Markdown
Contributor Author

@wing328 Now it's better. Why does did it take 18 commits to change two files 🤣

@wing328 wing328 removed this from the 5.2.1 milestone Aug 17, 2021
@wing328 wing328 added this to the 5.3.0 milestone Aug 17, 2021
@wing328

wing328 commented Aug 22, 2021

Copy link
Copy Markdown
Member

Gradle, maven plugin test failure already fixed in the master.

@wing328
wing328 merged commit bee8b61 into OpenAPITools:master Aug 22, 2021
@devhl-labs
devhl-labs deleted the enum-is-string branch August 22, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants