[java] fix deprecation warnings - #8969
Merged
Merged
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
wing328
added
the
Enhancement: Code Cleanup
agilob
approved these changes
Mar 14, 2021
Closed
5 tasks
| if (obj instanceof byte[]) { | ||
| // Binary (byte array) body parameter support. | ||
| return RequestBody.create(MediaType.parse(contentType), (byte[]) obj); | ||
| return RequestBody.create((byte[]) obj, MediaType.parse(contentType)); |
Contributor
There was a problem hiding this comment.
So far as I can tell, this has introduced a regression in the Java generator - see #9151.
toby-murray-snow-software
added a commit
to toby-murray-snow-software/openapi-generator
that referenced
this pull request
Apr 27, 2021
In 5.0.1 the generated line in `ApiClient` was: ``` return RequestBody.create(MediaType.parse(contentType), (byte[]) obj); ``` in 5.1.0 it is: ``` return RequestBody.create((byte[]) obj, MediaType.parse(contentType)); ``` Looks like this change was introduced in OpenAPITools#8969, and requires a more recent version of OkHttp to compile in some (all?) circumstances.
5 tasks
wing328
pushed a commit
that referenced
this pull request
Apr 28, 2021
In 5.0.1 the generated line in `ApiClient` was: ``` return RequestBody.create(MediaType.parse(contentType), (byte[]) obj); ``` in 5.1.0 it is: ``` return RequestBody.create((byte[]) obj, MediaType.parse(contentType)); ``` Looks like this change was introduced in #8969, and requires a more recent version of OkHttp to compile in some (all?) circumstances.
jxsl13
reviewed
Jun 30, 2021
| } else { | ||
| // use an empty request body (for POST, PUT and PATCH) | ||
| reqBody = RequestBody.create(MediaType.parse(contentType), ""); | ||
| reqBody = RequestBody.create("", MediaType.parse(contentType)); |
There was a problem hiding this comment.
why has this been swapped?
I'm getting errors that there is no such method signature found in okhttp client 4.9.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RequestBody.create()PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.xcc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)