[cpp-ue4] Added UE4.26 support, - #8964
Merged
Merged
Conversation
…started breaking.
…FHttpRequestRef for better portability
…try method on the response and SetAutoRetryCount on the request WIP auto retry [cpp-ue4] Adds support for instant retry
Member
|
cc @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08) |
Contributor
Author
|
Please note that the sample generation doesn't seem to work properly for cpp-ue4. But since the checks passed, I would love for this PR to be merged and the problem to be fixed in a separate PR (would also love some help for this). |
Member
|
@Kahncode I've pushed commits to update samples and remove some trailing spaces. Please have a look at the updated sample to see if it looks good to you. |
Contributor
Author
|
@wing328 This looks great, thanks! |
Member
|
@Kahncode thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added UE 4.26 support and improved compatibility in general.
Added support for automatic retries of a request
Fixed non-quoted enums which were broken by previous changes on master
Fixed datetime parsing with higher precision than millisecond
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x