Skip to content

[cpp-ue4] Added UE4.26 support, - #8964

Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom
Kahncode:ue4.26
Mar 17, 2021
Merged

[cpp-ue4] Added UE4.26 support, #8964
wing328 merged 8 commits into
OpenAPITools:masterfrom
Kahncode:ue4.26

Conversation

@Kahncode

Copy link
Copy Markdown
Contributor

Added UE 4.26 support and improved compatibility in general.
Added support for automatic retries of a request
Fixed non-quoted enums which were broken by previous changes on master
Fixed datetime parsing with higher precision than millisecond

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328

wing328 commented Mar 15, 2021

Copy link
Copy Markdown
Member

cc @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)

@Kahncode

Copy link
Copy Markdown
Contributor Author

Please note that the sample generation doesn't seem to work properly for cpp-ue4. But since the checks passed, I would love for this PR to be merged and the problem to be fixed in a separate PR (would also love some help for this).

@wing328

wing328 commented Mar 17, 2021

Copy link
Copy Markdown
Member

@Kahncode I've pushed commits to update samples and remove some trailing spaces. Please have a look at the updated sample to see if it looks good to you.

@Kahncode

Copy link
Copy Markdown
Contributor Author

@wing328 This looks great, thanks!

@wing328
wing328 merged commit 9ab3463 into OpenAPITools:master Mar 17, 2021
@wing328

wing328 commented Mar 22, 2021

Copy link
Copy Markdown
Member

@Kahncode thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423

@Kahncode
Kahncode deleted the ue4.26 branch May 24, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants