[Gradle Plugin] Allow to set additional property of any type. Useful for Boolean values. - #8507
Merged
Conversation
Member
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
Member
|
cc @OpenAPITools/generator-core-team |
xsveda
force-pushed
the
fix_only_string_values_can_be_set_as_additional_properties_through_gradle_plugin
branch
from
January 25, 2021 07:29
fcf859a to
7106673
Compare
xsveda
deleted the
fix_only_string_values_can_be_set_as_additional_properties_through_gradle_plugin
branch
March 6, 2021 21:12
Member
|
@xsveda thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle Plugin's
additionalPropertiesare of type Map<String, String>. When a project tries to set aBooleanproperty it needs to put it as a String (i.e. "true") which is not evaluated as properBooleanvalue by mustache template.This PR update
additionalPropertiestoMap<String, Any>.Use case comes from
moko-networklibrary: icerockdev/moko-network#59PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x