Skip to content

[powershell] Fix fields null check in powershell model template - #8323

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
dordadush:fix-null-check
Jan 5, 2021
Merged

[powershell] Fix fields null check in powershell model template#8323
wing328 merged 1 commit into
OpenAPITools:masterfrom
dordadush:fix-null-check

Conversation

@dordadush

@dordadush dordadush commented Jan 4, 2021

Copy link
Copy Markdown
Contributor

If field is boolean, the value might be $False.
The current null checking does not allow $False to be set.

@wing328

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

If field is boolean, the value might be $False.
The current null checking does not allow $False to be set.

@wing328 wing328 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328

wing328 commented Jan 5, 2021

Copy link
Copy Markdown
Member

CI failures not related to this change.

@wing328
wing328 merged commit 4cdf610 into OpenAPITools:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants