[dart][dart-dio] Improve prefixing of inner enums with classname - #8220
Closed
kuhnroyal wants to merge 2 commits into
Closed
[dart][dart-dio] Improve prefixing of inner enums with classname#8220kuhnroyal wants to merge 2 commits into
kuhnroyal wants to merge 2 commits into
Conversation
agilob
reviewed
Dec 17, 2020
Contributor
There was a problem hiding this comment.
mapTestMapOfEnumStringEnumSerializer 😆 and they say java is verbose
Contributor
Author
There was a problem hiding this comment.
😄 Well to be fair, its is private and generated to prevent collisions
kuhnroyal
force-pushed
the
dart/improve-inner-enum-naming
branch
from
December 17, 2020 14:33
f047a57 to
d14e11f
Compare
josh-burton
approved these changes
Dec 17, 2020
6 tasks
Contributor
Author
|
@wing328 This is now a breaking change with fallback (model name change?) after the 5.0.0 release and thus needs to go into the 5.1.0 branch? |
Member
That's correct. I've updated the target branch to |
kuhnroyal
force-pushed
the
dart/improve-inner-enum-naming
branch
from
January 8, 2021 13:23
b5877bf to
fa2fa77
Compare
* prevent further name conflicts by correctly naming the enum, until now there could potentially occur conflicts e.g. 2x `MapTestInnerEnum` by renaming the `items` child property * correctly set `enumName` to match `datatypeWithEnum`
kuhnroyal
force-pushed
the
dart/improve-inner-enum-naming
branch
from
February 2, 2021 00:38
fa2fa77 to
6903664
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MapTestInnerEnumby renaming theitemschild propertyenumNameto matchdatatypeWithEnumThe inline enum template has been changed but only enums that were previously called
InnerEnumhave been changed.I don't think that was supported before all the recent changes so I don't think this is a breaking change.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.masterCC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)