Skip to content

[go] Fix typo: "default GitHub in PRs" - #5302

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
SimonAlling:fix-typo-default-github-in-prs
Feb 13, 2020
Merged

[go] Fix typo: "default GitHub in PRs"#5302
wing328 merged 1 commit into
OpenAPITools:masterfrom
SimonAlling:fix-typo-default-github-in-prs

Conversation

@SimonAlling

@SimonAlling SimonAlling commented Feb 12, 2020

Copy link
Copy Markdown
Contributor

This passage confused me when I was reading this page:

whether to include Go codegen comment to disable Go Lint and collapse by default GitHub in PRs and diffs (Default: false)

I'm not entirely sure, but I think this PR proposes the intended formulation.

I'm not a Java expert, but I'm also wondering why GoClientCodegen.java has said string hardcoded instead of using WITH_GO_CODEGEN_COMMENT_DESC from CodegenConstants.java, but I guess that's a separate issue (if at all one).

PR checklist

  • Read the contribution guidelines.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

I assume this is what is meant by the last checkbox above: @antihax (2017/11) @bvwells (2017/12) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)

@auto-labeler

auto-labeler Bot commented Feb 12, 2020

Copy link
Copy Markdown

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@bkabrda bkabrda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch!

@jimschubert jimschubert added this to the 4.3.0 milestone Feb 13, 2020
@wing328
wing328 merged commit 5800698 into OpenAPITools:master Feb 13, 2020
MikailBag pushed a commit to MikailBag/openapi-generator that referenced this pull request Mar 23, 2020
@wing328

wing328 commented Mar 27, 2020

Copy link
Copy Markdown
Member

@SimonAlling thanks for the PR, which has been included in the 4.3.0 release: https://twitter.com/oas_generator/status/1243455743937789952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants