Skip to content

[typescript] Don't hardcode the date type if user has mapped it - #5266

Merged
macjohnny merged 6 commits into
OpenAPITools:masterfrom
asmundg:asmundg/respect-date-type-mapping
Feb 12, 2020
Merged

[typescript] Don't hardcode the date type if user has mapped it#5266
macjohnny merged 6 commits into
OpenAPITools:masterfrom
asmundg:asmundg/respect-date-type-mapping

Conversation

@asmundg

@asmundg asmundg commented Feb 10, 2020

Copy link
Copy Markdown
Contributor

If the user has set --type-mappings Date=foo, respect this setting
instead of hardcoding the date type.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants