[rust-server]: Fix NPE - #5213
Closed
mvniekerk wants to merge 1 commit into
Closed
Conversation
Contributor
Author
jimschubert
reviewed
Feb 6, 2020
jimschubert
left a comment
Member
There was a problem hiding this comment.
Is this actually a user-facing error? I feel like someone running the generator would see this message and think generation has failed or skipped something important.
Would you consider removing the error and just inverting your equals check to avoid the NPE?
if( uuidType.equals(param.dataType) ) {
Member
|
I've filed #5304 with @jimschubert suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had an NPE due to a malformed OAS YAML file. This 3 liner fixes the frailty on this malformed-ness and spews out an error message with the offending parameter.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.