Skip to content

kotlin-spring: minor updates - #24663

Merged
wing328 merged 1 commit into
masterfrom
kotlin-spring-update
Aug 10, 2026
Merged

kotlin-spring: minor updates#24663
wing328 merged 1 commit into
masterfrom
kotlin-spring-update

Conversation

@wing328

@wing328 wing328 commented Aug 10, 2026

Copy link
Copy Markdown
Member

fyi @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10)

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Refactored Kotlin Spring server codegen to use Lombok for accessors and make internal fields final. No behavior or generated code changes.

  • Refactors
    • Replaced manual getDescription() in RequestMappingMode with @Getter; made description final.
    • Applied @Getter/@Setter to requestMappingMode and removed manual accessors.
    • Marked modelToSealedInterfaces and sealedInterfaceToOperationId as final.
    • Simplified a return type assignment by inlining a temporary variable.

Written for commit c3aee85. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@wing328 wing328 added this to the 7.25.0 milestone Aug 10, 2026
@wing328
wing328 merged commit bd58fdc into master Aug 10, 2026
15 checks passed
@wing328
wing328 deleted the kotlin-spring-update branch August 10, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant