Skip to content

Clean up interfaceOnly option - #24657

Merged
wing328 merged 2 commits into
masterfrom
interface-only
Aug 10, 2026
Merged

Clean up interfaceOnly option#24657
wing328 merged 2 commits into
masterfrom
interface-only

Conversation

@wing328

@wing328 wing328 commented Aug 10, 2026

Copy link
Copy Markdown
Member

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Standardized the interfaceOnly option across server generators by centralizing its key/description and updating docs/tests. Also clarified Go Gin help text to state it generates stubs instead of implementation files.

  • Refactors
    • Added CodegenConstants.INTERFACE_ONLY and INTERFACE_ONLY_DESC.
    • Switched GoGinServerCodegen, JavaDubboServerCodegen, JavaJAXRSSpecServerCodegen, JavaVertXWebServerCodegen, KotlinServerCodegen, KotlinSpringServerCodegen, and SpringCodegen to the shared key; removed local duplicates.
    • Unified help text to “Whether to generate only API interface stubs without the server files.”; for Go Gin, clarified wording to “Whether to generate only API interface stubs instead of the API implementation files.” and updated docs/generators/go-gin-server.md.
    • Updated tests to reference the shared constant and cleaned up minor assertions.

Written for commit 5e1d404. Summary will update on new commits.

Review in cubic

@wing328 wing328 added the Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. label Aug 10, 2026
@wing328
wing328 marked this pull request as ready for review August 10, 2026 05:03

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 15 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread docs/generators/go-gin-server.md Outdated
@wing328 wing328 added this to the 7.25.0 milestone Aug 10, 2026
@wing328 wing328 changed the title Clean up interface only option Clean up interfaceOnly option Aug 10, 2026
@wing328
wing328 merged commit c5ee1a7 into master Aug 10, 2026
15 checks passed
@wing328
wing328 deleted the interface-only branch August 10, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant