[Go]: Avoid name collisions of case-sensitive properties - #24624
Closed
thiagoarrais wants to merge 1 commit into
Closed
[Go]: Avoid name collisions of case-sensitive properties#24624thiagoarrais wants to merge 1 commit into
thiagoarrais wants to merge 1 commit into
Conversation
Contributor
|
I believe the best approach is to use the already existing name-mapping setting to handle these scenarios. |
Contributor
Author
|
Closing in favor of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the Go generator to avoid possible name collisions due to case-sensitive object property names. The input spec may specify two properties named
Fooandfoo, and the generated Go code would (before this PR) include two fields namedFooin the same struct.This may be applicable to other languages as well.
Golang committee: @antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5
PR checklist
Summary by cubic
Fixes Go code generation to prevent struct field collisions when properties differ only by case. Conflicting fields now get a stable
P_prefix so the generated code compiles and remains unambiguous.Bug Fixes
P_<baseName>.name,Name,FirstName,first_name->Name,P_Name,FirstName,P_first_name.Migration
P_<baseName>. Update any references accordingly.Written for commit b126649. Summary will update on new commits.