Skip to content

Do not import ApiClient when supportUrlQuery is false - #23708

Merged
wing328 merged 3 commits into
OpenAPITools:masterfrom
sjw2547:feature/23700
May 7, 2026
Merged

Do not import ApiClient when supportUrlQuery is false#23708
wing328 merged 3 commits into
OpenAPITools:masterfrom
sjw2547:feature/23700

Conversation

@sjw2547

@sjw2547 sjw2547 commented May 6, 2026

Copy link
Copy Markdown
Contributor

Fixes #23700

When generating only models and JSON related supporting file with the supportUrlQuery as false, invalid unused import for ApiClient is included for generated Java classes that are defined as OneOf or AnyOf in the OpenAPI specification. PR does not include the ApiClient import in these classes if supportUrlQuery is false.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Skip importing ApiClient in generated Java oneOf/anyOf model classes when supportUrlQuery is false to remove unused import errors; regenerate Java native sample models and remove a stray debug comment. Fixes #23700.

  • Bug Fixes
    • Guard the ApiClient import in anyof_model.mustache and oneof_model.mustache behind {{#supportUrlQuery}} so model-only/JSON-only generation doesn’t include it.
    • Remove an unnecessary debug comment from the generated output.

Written for commit 77c3431. Summary will update on new commits.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@wing328 wing328 added this to the 7.23.0 milestone May 7, 2026
@wing328
wing328 merged commit 0867b16 into OpenAPITools:master May 7, 2026
15 checks passed
@wing328 wing328 changed the title #23700 Do not import ApiClient when supportUrlQuery is false Do not import ApiClient when supportUrlQuery is false Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][JAVA] Generating native Java models with AllOf/OneOf definitions without creating client creates a model with unused imports

2 participants