Skip to content

[java] Support 'date-time-local' format - #23395

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
Allsimon:dateTimeLocal
May 5, 2026
Merged

[java] Support 'date-time-local' format#23395
wing328 merged 1 commit into
OpenAPITools:masterfrom
Allsimon:dateTimeLocal

Conversation

@Allsimon

@Allsimon Allsimon commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

See https://spec.openapis.org/registry/format/date-time-local.html

fixes #13889

@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Add support for the OpenAPI date-time-local format in the Java/Spring generator. Maps to LocalDateTime (java.time.LocalDateTime) and parses defaults when the java8 date library is used; fixes #13889.

  • New Features
    • Map date-time-localLocalDateTime in AbstractJavaCodegen; always import java.time.LocalDateTime; add ModelUtils.isDateTimeLocalSchema.
    • Parse date-time-local defaults via LocalDateTime.parse(...) when using java8 (including nested object properties). Add unit tests (Java + Spring) and regenerate samples (Pet.adoptionDate with default).

Written for commit 1674477. Summary will update on new commits.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java">

<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java:2661">
P2: New format handling uses mismatched keys (`date-time-local` vs `local-date`), so the added `date-time-local` property post-processing branch will not execute.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread modules/openapi-generator/src/test/resources/3_0/spring/date-time-local.yml Outdated
@wing328

wing328 commented Apr 1, 2026

Copy link
Copy Markdown
Member

https://github.com/OpenAPITools/openapi-generator/actions/runs/23816722621/job/69487441944?pr=23395

please update the samples to fix this

@Allsimon
Allsimon force-pushed the dateTimeLocal branch 3 times, most recently from c33bc7f to aee5ba3 Compare April 5, 2026 11:10
@Allsimon
Allsimon marked this pull request as ready for review April 5, 2026 11:14

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 7 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java">

<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJavaCodegen.java:1417">
P2: `date-time-local` default generation is incorrectly limited to `dateLibrary=java8`, so `java8-localdatetime` silently loses declared defaults.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@Chrimle Chrimle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Allsimon Allsimon changed the title [spring] Support 'date-time-local' format [java] Support 'date-time-local' format Apr 12, 2026
@wing328 wing328 modified the milestones: 7.22.0, 7.23.0 Apr 28, 2026
@wing328
wing328 merged commit 8cd32ab into OpenAPITools:master May 5, 2026
50 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][JAVA] Implement adapter for java.time.LocalDateTime in client code

3 participants