fix(typescript): add trailing commas to as const enums - #23277
Closed
scarf005 wants to merge 1 commit into
Closed
Conversation
scarf005
marked this pull request as ready for review
March 24, 2026 00:40
…23275) Keep enum object diffs smaller across Angular, Fetch, and NestJS server generators.
scarf005
force-pushed
the
fix/typescript-as-const-trailing-commas
branch
from
March 24, 2026 00:51
b11c3b1 to
d9cb3b1
Compare
Chrimle
approved these changes
Mar 25, 2026
Chrimle
left a comment
Contributor
There was a problem hiding this comment.
Looks good, although I am in the camp of "don't add redundant/trailing commas because it is just clutter, and decreases readability".
3 tasks
Member
|
merged via #24693 closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
as constenum objects in typescript-angular, typescript-fetch, and typescript-nestjs-servercontinuation of #23275
PR opened by gpt-5.4 xhigh on opencode
Summary by cubic
Generate
as constenum objects with trailing commas to reduce diff noise and align with common TS style across generators. Updates templates fortypescript-angular,typescript-fetch, andtypescript-nestjs-server, and adds shared regression coverage across generators.typescript-angular,typescript-fetch, andtypescript-nestjs-servertemplates.typescript-angular,typescript-fetch,typescript-nestjs-server, andtypescript-axios.Written for commit d9cb3b1. Summary will update on new commits.