Skip to content

Add doc goal for scala-maven-plugin - #22734

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
lostiniceland:fix-release
Jan 19, 2026
Merged

Add doc goal for scala-maven-plugin#22734
wing328 merged 1 commit into
OpenAPITools:masterfrom
lostiniceland:fix-release

Conversation

@lostiniceland

@lostiniceland lostiniceland commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

should resolve #22652 (comment)


Summary by cubic

Add the doc-jar goal to the scala-maven-plugin for the mill plugin so a ScalaDoc JAR is built during the release. This fixes the missing docs artifact noted in the PR #22652 discussion and unblocks the release.

Written for commit 5881a3d. Summary will update on new commits.

@wing328

wing328 commented Jan 19, 2026

Copy link
Copy Markdown
Member

thanks for the quick fix. let's give it a try

@wing328
wing328 merged commit a62ed1d into OpenAPITools:master Jan 19, 2026
2 of 12 checks passed

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@wing328

wing328 commented Jan 19, 2026

Copy link
Copy Markdown
Member

got an error when running mvn clean install

[INFO] --- scala:4.9.5:doc-jar (default) @ openapi-generator-mill-plugin ---
bad option '-doc-format:html' was ignored
bad option '-doc-title' was ignored
source file not found: openapi-generator-mill-plugin 7.19.0 API
2 warnings found
1 error found
[INFO] ------------------------------------------------------------------------

@wing328

wing328 commented Jan 19, 2026

Copy link
Copy Markdown
Member

tried various configuration in pom.xml (mill plugin) but no luck

looks like the only choice left is to remove mill plugin from the release and put it in a separate repo for release.

@wing328

wing328 commented Jan 19, 2026

Copy link
Copy Markdown
Member

Filed #22736 to remove the plugin

@wing328

wing328 commented Jan 19, 2026

Copy link
Copy Markdown
Member

now the publishing job completes without issues: https://github.com/OpenAPITools/openapi-generator/actions/runs/21146336842

@lostiniceland

Copy link
Copy Markdown
Contributor Author

This PR should fix it

@wing328

wing328 commented Feb 11, 2026

Copy link
Copy Markdown
Member

FYI. Just saw this in the build log

[INFO] --- scala-maven-plugin:4.9.5:testCompile (default) @ openapi-generator-mill-plugin ---
[INFO] compiling 1 Scala source to C:\Users\User\code\openapi-generator2\modules\openapi-generator-mill-plugin\target\test-classes ...
[WARNING] C:/Users/User/code/openapi-generator2/modules/openapi-generator-mill-plugin/src/test/scala/org/openapitools/generator/mill/MillOpenapiModuleTest.scala:98:28: `_` is deprecated for wildcard arguments of types: use `?` instead
This construct can be rewritten automatically under -rewrite -source 3.4-migration.
[WARNING] C:/Users/User/code/openapi-generator2/modules/openapi-generator-mill-plugin/src/test/scala/org/openapitools/generator/mill/MillOpenapiModuleTest.scala:98:31: `_` is deprecated for wildcard arguments of types: use `?` instead
This construct can be rewritten automatically under -rewrite -source 3.4-migration.
[WARNING] C:/Users/User/code/openapi-generator2/modules/openapi-generator-mill-plugin/src/test/scala/org/openapitools/generator/mill/MillOpenapiModuleTest.scala:107:27: `_` is deprecated for wildcard arguments of types: use `?` instead
This construct can be rewritten automatically under -rewrite -source 3.4-migration.
[WARNING] C:/Users/User/code/openapi-generator2/modules/openapi-generator-mill-plugin/src/test/scala/org/openapitools/generator/mill/MillOpenapiModuleTest.scala:107:30: `_` is deprecated for wildcard arguments of types: use `?` instead
This construct can be rewritten automatically under -rewrite -source 3.4-migration.
[WARNING] four warnings found

these warnings in tests are pretty minor so we can release what we have so far later this week

@wing328 wing328 added this to the 7.20.0 milestone Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants