update akka-http and pekko-http server generator and example - #21166
Merged
wing328 merged 1 commit intoApr 29, 2025
Conversation
xuwei-k
force-pushed
the
akka-pekko-server-fix-warnings
branch
from
April 28, 2025 11:02
465baf4 to
ce6c5da
Compare
xuwei-k
force-pushed
the
akka-pekko-server-fix-warnings
branch
from
April 28, 2025 11:16
ce6c5da to
2dbffa0
Compare
xuwei-k
commented
Apr 28, 2025
| import {{akkaImportGroupId}}.http.scaladsl.server.Directives._ | ||
| import {{akkaImportGroupId}}.actor.ActorSystem | ||
| import {{akkaImportGroupId}}.stream.ActorMaterializer | ||
| import {{akkaImportGroupId}}.stream.Materializer |
Contributor
Author
There was a problem hiding this comment.
ActorMaterializer is deprecated
xuwei-k
commented
Apr 28, 2025
Comment on lines
14
to
+15
|
|
||
| Http().bindAndHandle(routes, "0.0.0.0", 9000) | ||
| } No newline at end of file | ||
| Http().newServerAt("0.0.0.0", 9000).bind(routes) |
Contributor
Author
There was a problem hiding this comment.
bindAndHandle is deprecated
xuwei-k
commented
Apr 28, 2025
| import {{akkaImportGroupId}}.http.scaladsl.unmarshalling.Unmarshaller.UnsupportedContentTypeException | ||
|
|
||
| import scala.concurrent.Future | ||
| import scala.language.implicitConversions |
Contributor
Author
There was a problem hiding this comment.
avoid warnings
[warn] tmp/samples/server/petstore/scala-pekko-http-server/src/main/scala/org/openapitools/server/StringDirectives.scala:12:16: implicit conversion method _symbol2NR should be enabled
[warn] by making the implicit value scala.language.implicitConversions visible.
[warn] This can be achieved by adding the import clause 'import scala.language.implicitConversions'
[warn] or by setting the compiler option -language:implicitConversions.
[warn] See the Scaladoc for value scala.language.implicitConversions for a discussion
[warn] why the feature should be explicitly enabled.
[warn] implicit def _symbol2NR(symbol: Symbol): NameReceptacle[String] = new NameReceptacle[String](symbol.name)
[warn] ^
[warn] tmp/samples/server/petstore/scala-pekko-http-server/src/main/scala/org/openapitools/server/StringDirectives.scala:13:16: implicit conversion method _string2NR should be enabled
[warn] by making the implicit value scala.language.implicitConversions visible.
[warn] implicit def _string2NR(string: String): NameReceptacle[String] = new NameReceptacle[String](string)
[warn] ^
[warn] tmp/samples/server/petstore/scala-pekko-http-server/src/main/scala/org/openapitools/server/StringDirectives.scala:31:18: implicit conversion method apply should be enabled
[warn] by making the implicit value scala.language.implicitConversions visible.
[warn] implicit def apply[T](value: T)(implicit sdef: StringDef[T]): StringMagnet { type Out = sdef.Out } =
[warn] ^
[warn] three warnings found
xuwei-k
marked this pull request as ready for review
April 28, 2025 11:39
Member
|
cc @clasnake (2017/07), @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04) @Fish86 (2023/06) |
Contributor
|
Approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix some warnings and update akka, pekko and scala versions.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)