[Rust-Axum] Support quotes in string literals - #20176
Merged
wing328 merged 2 commits intoNov 26, 2024
Merged
Conversation
Victoria-Casasampere-BeeTheData
force-pushed
the
rust-axum-quotes-in-literals
branch
from
November 25, 2024 16:28
588c33a to
5edb04a
Compare
Victoria-Casasampere-BeeTheData
marked this pull request as ready for review
November 25, 2024 16:33
Contributor
Author
|
Ready for merging @wing328 |
Victoria-Casasampere-BeeTheData
force-pushed
the
rust-axum-quotes-in-literals
branch
from
November 26, 2024 11:43
5edb04a to
4052c4a
Compare
linxGnu
approved these changes
Nov 26, 2024
linxGnu
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for great contribution @Victoria-Casasampere-BeeTheData
Victoria-Casasampere-BeeTheData
deleted the
rust-axum-quotes-in-literals
branch
November 26, 2024 14:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows quotes to be used in string default values. Currently, using
default: "test \"foo\" bar"leads to code that fails to compile. This patch puts all string literals inr#""#, solving the issue.Depends on:
Samples will be updated when they merge, but they should not have any merge conflicts.
@linxGnu @wing328
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples, as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)