Skip to content

feat (#19407 JAVA SPRING WEBCLIENT): Add support for useSingleRequestParameter to Spring WebClient - #19827

Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom
Nicklas2751:feature/19407_webclient_singlerequestparameter
Dec 15, 2024
Merged

feat (#19407 JAVA SPRING WEBCLIENT): Add support for useSingleRequestParameter to Spring WebClient#19827
wing328 merged 8 commits into
OpenAPITools:masterfrom
Nicklas2751:feature/19407_webclient_singlerequestparameter

Conversation

@Nicklas2751

@Nicklas2751 Nicklas2751 commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

As Requested with #19407 I added support for useSingleRequestParameter to the Spring WebClient

Closes #19407

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@Nicklas2751
Nicklas2751 force-pushed the feature/19407_webclient_singlerequestparameter branch from b547f68 to 965850a Compare October 10, 2024 19:32
@Nicklas2751

Copy link
Copy Markdown
Contributor Author

1 check failed because I rebased my branch with the current master branch which triggered the (not working) scala action

@wing328

wing328 commented Oct 16, 2024

Copy link
Copy Markdown
Member

@Nicklas2751
Nicklas2751 force-pushed the feature/19407_webclient_singlerequestparameter branch from 965850a to b05c91c Compare October 17, 2024 21:33
@Nicklas2751

Copy link
Copy Markdown
Contributor Author

@wing328 This is done. I also rebased with the latest upstream master :)

@Nicklas2751
Nicklas2751 requested a review from wing328 October 31, 2024 08:25
@Nicklas2751
Nicklas2751 force-pushed the feature/19407_webclient_singlerequestparameter branch from b05c91c to 3492eb4 Compare December 14, 2024 19:43
@wing328 wing328 modified the milestones: 7.10.0, 7.11.0 Dec 15, 2024
@wing328
wing328 merged commit 07d19ba into OpenAPITools:master Dec 15, 2024
@wing328

wing328 commented Dec 15, 2024

Copy link
Copy Markdown
Member

Sorry for the delay. Just merged the PR.

Thanks again for your contribution.

@Nicklas2751
Nicklas2751 deleted the feature/19407_webclient_singlerequestparameter branch December 27, 2024 20:21
timon-sbr pushed a commit to timon-sbr/openapi-generator that referenced this pull request Mar 13, 2025
…ingleRequestParameter to Spring WebClient (OpenAPITools#19827)

* chore (JAVA SPRING WEBCLIENT): Remove comments used for debugging

* feat (JAVA SPRING WEBCLIENT): Add support for useSingleRequestParameter to Spring WebClient

* feat (JAVA SPRING WEBCLIENT): Generate samples and docs

* fix (JAVA SPRING WEBCLIENT): Fix missing return error & Fix JDK17 action webclient useSingleRequestParameter test path

* fix (JAVA SPRING WEBCLIENT): Fix code indention

* fix (JAVA SPRING WEBCLIENT): Fix code indention again

* fix (JAVA SPRING WEBCLIENT): Update samples

* feat (JAVA SPRING WEBCLIENT): Regenerate after pull rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ][Java][Client][WebClient] Group Parameters as one parameter (useSingleRequestParameter) for Spring WebClient

3 participants