Remove calculateRequestOrder Function and fix bug - #19685
Merged
wing328 merged 7 commits intoOct 8, 2024
Merged
Conversation
added 2 commits
September 26, 2024 11:25
This PR removes the calculateRequestOrder function from the codebase and addresses the bug described in issue #19110. After a thorough review, it was determined that the function was unnecessary due to its redundant logic and lack of unique functionality.
Member
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
Member
|
cc @mostafa |
…/github.com/DevMrRober/openapi-generator into fix/remove-calculateRequestOrder-issue19110
This PR removes the calculateRequestOrder function from the codebase and addresses the bug described in issue #19110. After a thorough review, it was determined that the function was unnecessary due to its redundant logic and lack of unique functionality.
…/github.com/DevMrRober/openapi-generator into fix/remove-calculateRequestOrder-issue19110
Contributor
Author
|
Sorry, I made a mistake the first time, it should be right now. |
mostafa
approved these changes
Sep 28, 2024
mostafa
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for your contribution.
Contributor
Author
|
@wing328 when will this PR be applied? |
Member
|
just merged. thanks for the PR samples updated via 25b8341 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
calculateRequestOrderfunction. The previous function was deemed unnecessary due to its redundant logic and lack of unique functionality.Changes made
Removed function
calculateRequestOrderRemoved call to
calculateRequestOrderfunction, which calculated the order of requests based onoperationGroupingOrderandrequestsSize.Updated request creation logic:
requests.size()as the key inrequests.putIfAbsent(), ensuring that each new request is added with a unique identifier based on the current size of the request map.Reason for change
Tests
Related issue
Reviewers