[php] Set $multipart to true if content-type is multipart/form-data (#5536) - #18991
Merged
wing328 merged 3 commits intoDec 15, 2024
Merged
[php] Set $multipart to true if content-type is multipart/form-data (#5536)#18991wing328 merged 3 commits into
wing328 merged 3 commits into
Conversation
Contributor
Author
|
TC mentions: @jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon |
simonhammes
commented
Jun 21, 2024
Member
|
@simonhammes thanks for the PR, which has been merged. Sorry for taking a bit long to review. |
Contributor
Author
|
@wing328 Thanks for merging!
No worries 🙂 |
timon-sbr
pushed a commit
to timon-sbr/openapi-generator
that referenced
this pull request
Mar 13, 2025
…penAPITools#5536) (OpenAPITools#18991) * [php] Set $multipart to true if content-type is multipart/form-data (OpenAPITools#5536) Related: OpenAPITools#5536 * [php] Use isMultipart variable --------- Co-authored-by: Simon Hammes <simonhammes@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PHP client does not correctly identify multipart/form-data requests without files. See #5536 (comment) for details.
This PR fixes this bug.
Related: #5536
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)