Skip to content

[Kotlin][Multiplatform] Upgrade Kotlin to version 1.6.0 - #11022

Merged
4brunu merged 1 commit into
OpenAPITools:masterfrom
Airthings:kotlin-1.6.0
Feb 11, 2022
Merged

[Kotlin][Multiplatform] Upgrade Kotlin to version 1.6.0#11022
4brunu merged 1 commit into
OpenAPITools:masterfrom
Airthings:kotlin-1.6.0

Conversation

@tkirshboim

@tkirshboim tkirshboim commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

PR Description

  • The PR upgrades the Kotlin version used by the Kotlin Multiplatform template to version 1.6.0.
  • Ktor is upgraded to version 1.6.4, the the recommended version to use with Kotlin 1.6.0.

Upgrading to 1.6.0 was deliberately avoided in #10900 because Jetpack Compose was not compatible with Kotlin 1.6.0. This issue is now resolved because Jetpack Compose can be used with Kotlin 1.6.0 when using Compose compiler version 1.1.0-beta04.

This change was validated in KMM demo project that uses this branch to generate the petstore sample code and Jetpack Compose: Airthings/openapi-multiplatform-multi-module@050f086

CCs

Kotlin technical committee:
@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@tkirshboim tkirshboim changed the title [Kotlin][Multiplatform] Upgrade to Kotlin to version 1.6.0 [Kotlin][Multiplatform] Upgrade Kotlin to version 1.6.0 Dec 2, 2021
@4brunu

4brunu commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

Hey, thanks for creating this PR.
Since the jetpack compose stable is still using kotlin 1.5.32, maybe we should wait a bit more to merge this PR?
What do you think?

@tkirshboim

Copy link
Copy Markdown
Contributor Author

Since the jetpack compose stable is still using kotlin 1.5.32, maybe we should wait a bit more to merge this PR? What do you think?

@4brunu That's a good point. I'm using the beta version, but I'm fine with waiting if you prefer.

@4brunu

4brunu commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

The PR looks good to me, but I would prefer for that jetpack compose stable version to adopt 1.6.0, and then we could merge this PR.
Is it ok to you?

@tkirshboim

Copy link
Copy Markdown
Contributor Author

The PR looks good to me, but I would prefer for that jetpack compose stable version to adopt 1.6.0, and then we could merge this PR. Is it ok to you?

Sure! :)

@4brunu

4brunu commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

Nice, by the way, thanks for creating some PRs to the kotlin multiplatform generator 👍

@xxfast

xxfast commented Feb 11, 2022

Copy link
Copy Markdown

Can this be merged, please?

@4brunu

4brunu commented Feb 11, 2022

Copy link
Copy Markdown
Contributor

Now that jetpack compose 1.1.0 is stable, we can merge this PR 👍
If anyone want's to open another PR to update kotlin to 1.6.10 is welcome 🙂

@4brunu
4brunu merged commit 01a8572 into OpenAPITools:master Feb 11, 2022
@tkirshboim
tkirshboim deleted the kotlin-1.6.0 branch February 11, 2022 12:29
@wing328 wing328 added this to the 6.0.0 milestone Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants