Skip to content

[java] use IllegalArgumentException instead of RuntimeException - #10745

Merged
wing328 merged 1 commit into
6.0.xfrom
jersey2-exception
Nov 2, 2021
Merged

[java] use IllegalArgumentException instead of RuntimeException#10745
wing328 merged 1 commit into
6.0.xfrom
jersey2-exception

Conversation

@wing328

@wing328 wing328 commented Oct 31, 2021

Copy link
Copy Markdown
Member
  • use IllegalArgumentException instead of RuntimeException as suggested by code review

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328

wing328 commented Nov 1, 2021

Copy link
Copy Markdown
Member Author

Groovy test failure not related to this change.

@wing328

wing328 commented Nov 2, 2021

Copy link
Copy Markdown
Member Author

CI failure already fixed in the master.

@wing328
wing328 merged commit 48f81ee into 6.0.x Nov 2, 2021
@wing328
wing328 deleted the jersey2-exception branch November 2, 2021 04:47
@wing328 wing328 modified the milestones: 5.3.1, 6.0.0 Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant