Skip to content

Add "parentOverridden" support in every JaxRS pom.mustache templates - #10132

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
scali:fix-jaxrs-parent-pom
Aug 18, 2021
Merged

Add "parentOverridden" support in every JaxRS pom.mustache templates#10132
wing328 merged 1 commit into
OpenAPITools:masterfrom
scali:fix-jaxrs-parent-pom

Conversation

@scali

@scali scali commented Aug 11, 2021

Copy link
Copy Markdown
Contributor

Fix #8890 (only part 2 of the issue)

  • At first glance : I apply the change only in Jaxrs-Jersey pom.mustache template
  • After a closer look : I apply the change to every JaxRS pom.mustache templates

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @nmuesch

@wing328

wing328 commented Aug 15, 2021

Copy link
Copy Markdown
Member

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@scali

scali commented Aug 17, 2021

Copy link
Copy Markdown
Contributor Author

Should I cancel this PR and make a new one with the updated commits ?

@scali

scali commented Aug 17, 2021

Copy link
Copy Markdown
Contributor Author

I've tried another solution : I've added the email address used in the commit so that the contibution sould be linked to my github account

@wing328

wing328 commented Aug 18, 2021

Copy link
Copy Markdown
Member

LGTM. Will update the samples in another commit

@wing328
wing328 merged commit d9f3a02 into OpenAPITools:master Aug 18, 2021
@wing328 wing328 changed the title Fix #8890 (part 2) in every JaxRS pom.mustache templates Add "parentOverridden" support in every JaxRS pom.mustache templates Aug 18, 2021
@scali
scali deleted the fix-jaxrs-parent-pom branch August 19, 2021 14:34
@wing328 wing328 added this to the 5.3.0 milestone Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Jaxrs-Jersey produces server that doesn't compile + doesn't handle parent tag in pom.xml correctly

2 participants