Skip to content

[markdown] Add primitive types to Markdown generator (#5449) - #10106

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
michaelgrahamevans:markdown-links
Aug 18, 2021
Merged

[markdown] Add primitive types to Markdown generator (#5449)#10106
wing328 merged 1 commit into
OpenAPITools:masterfrom
michaelgrahamevans:markdown-links

Conversation

@michaelgrahamevans

Copy link
Copy Markdown
Contributor

Adds primitive types to the Markdown generator to resolve #5449, which also resolves #6096. Adds a new OpenAPI spec (issue_6096.yaml) with many primitive types and tests that show that the primitive types are no longer linked to in the generated Markdown.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328

wing328 commented Aug 18, 2021

Copy link
Copy Markdown
Member

cc @jimschubert (the author of the markdown generator)

@wing328 wing328 added this to the 5.3.0 milestone Aug 18, 2021
@wing328
wing328 merged commit 4da3d45 into OpenAPITools:master Aug 18, 2021
@michaelgrahamevans
michaelgrahamevans deleted the markdown-links branch August 22, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][MARKDOWN] Basic types create invalid links to Model [BUG][MARKDOWN] Primitive Type not set to true for primitives on Models

2 participants